Skip to content

refactor: enhance organization redirection logic across dashboard lay…#301

Merged
claudfuen merged 1 commit into
mainfrom
claudio/launch-prep
Apr 4, 2025
Merged

refactor: enhance organization redirection logic across dashboard lay…#301
claudfuen merged 1 commit into
mainfrom
claudio/launch-prep

Conversation

@claudfuen
Copy link
Copy Markdown
Contributor

@claudfuen claudfuen commented Apr 4, 2025

…outs

  • Added checks for active organization ID in the layout and dashboard page to ensure proper redirection.
  • Simplified the session handling in the setup page and updated the Onboarding component for improved clarity and modularity.
  • Removed unnecessary authentication checks in the frameworks layout to streamline the component structure.

Summary by CodeRabbit

  • New Features

    • Improved navigation across the app. Users are now redirected smoothly based on their active organization, ensuring a more intuitive dashboard and setup experience.
    • Organization creation now results in an immediate redirect, reducing wait times and streamlining the onboarding process.
  • Style

    • Enhanced the authentication page’s appearance with updated visual elements to improve content clarity.

…outs

- Added checks for active organization ID in the layout and dashboard page to ensure proper redirection.
- Simplified the session handling in the setup page and updated the Onboarding component for improved clarity and modularity.
- Removed unnecessary authentication checks in the frameworks layout to streamline the component structure.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app 🔄 Building (Inspect) Visit Preview 💬 Add feedback Apr 4, 2025 3:41am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
comp-portal ⬜️ Skipped (Inspect) Apr 4, 2025 3:41am

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 4, 2025

CLA assistant check
All committers have signed the CLA.

@claudfuen claudfuen merged commit 791292e into main Apr 4, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request refactors several components across the dashboard, setup, and authentication areas. In the dashboard pages, session management, internationalization, and redirection logic have been either removed or streamlined; the DashboardPage now directly uses parameters for redirection. The setup page has been updated to use a client component with improved header handling and redirection flow. Additionally, minor formatting adjustments and import optimizations were made in the public auth and Google sign-in components, and the organization creation form now exports the client function and removes delayed navigation.

Changes

File(s) Change Summary
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/frameworks/layout.tsx Removed imports (getI18n, auth, headers, redirect) and the associated logic for internationalization and session management.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/layout.tsx Added a conditional check for activeOrganizationId in the session with a redirect to / if missing.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/page.tsx Refactored DashboardPage to accept a params promise for orgId extraction, eliminating session-based authentication and redirecting to /${orgId}/frameworks.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/frameworks/page.tsx Reordered the import for PageWithBreadcrumb without affecting functionality.
apps/app/src/app/[locale]/(app)/setup/page.tsx Updated to render OnboardingClient instead of Onboarding, consolidated header retrieval, and streamlined redirection logic based on session state.
apps/app/src/app/[locale]/(public)/auth/page.tsx Made formatting adjustments and added a border CSS class to the wrapping div.
apps/app/src/components/forms/create-organization-form.tsx Exported OnboardingClient, removed the setTimeout delay for navigation, and removed the redundant Onboarding function.
apps/app/src/components/google-sign-in.tsx Removed the next/router import and added back the authClient import from utilities.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant DP as DashboardPage
    participant P as Params Resolver
    U->>DP: Request Dashboard Page
    DP->>P: Await params { orgId }
    P-->>DP: Return { orgId }
    DP->>DP: Redirect to "/{orgId}/frameworks"
Loading
sequenceDiagram
    participant U as User
    participant L as Layout Component
    participant S as Session Checker
    U->>L: Request Dashboard Layout
    L->>S: Verify session & activeOrganizationId
    alt Missing activeOrganizationId
        L->>U: Redirect to "/"
    else Valid activeOrganizationId
        L->>U: Render Dashboard Layout
    end
Loading

Possibly related PRs

Poem

I'm a rabbit skipping through the code maze,
Hopping past sessions in swift, neat phase.
Imports leap away and checks now stay light,
With streamlined paths, our code's taking flight.
Carrot-fueled commits make each line a delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 618400f and 918e06a.

📒 Files selected for processing (8)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/frameworks/layout.tsx (0 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/frameworks/page.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/layout.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/page.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/setup/page.tsx (3 hunks)
  • apps/app/src/app/[locale]/(public)/auth/page.tsx (1 hunks)
  • apps/app/src/components/forms/create-organization-form.tsx (3 hunks)
  • apps/app/src/components/google-sign-in.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants