fix(app): hide evidence tasks not added to the org (no more "Not added")#3006
Merged
Conversation
The service detail "Evidence provided" list and the provider "Evidence tasks" list rendered template mappings that have no live task in the org as "Not added", which prompts customers to ask why a task isn't added. Show only evidence tasks that actually exist in the org, and make each list's count match what's shown. Applies to all cloud providers (shared components). - ServiceDetailView + IntegrationEvidenceTasks: filter mapped tasks to those resolved against the org's task templates; counts reflect the filtered set. - ServiceDetailView preserves the tasks-fetch-error case: when the fetch failed we can't distinguish added from not-added, so show all (the row reads "Couldn't load" instead of a misleading "Not added"). - Tests for both components. Follow-up (not in this PR): the service card's task-count badge in the grid still shows total mapped tasks; threading org task templates into the grid would make that count match the detail too. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.68.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the integration service detail page (e.g. Amazon Web Services → S3 Bucket Security → "Evidence provided") and the provider-level "Evidence tasks" list, mapped task templates that have no live task in the org render as "Not added". Customers see that and ask "why isn't this added?" — which we don't want. Affects all cloud providers (shared components).
Fix
Show only evidence tasks that actually exist in the org, and make each list's count match what's shown:
ServiceDetailView+IntegrationEvidenceTasks: filter mapped tasks to those resolved against the org's task templates; the count badge reflects the filtered set.ServiceDetailViewpreserves the tasks-fetch-error case: on a real fetch error we can't distinguish added vs not-added, so it shows all rows (which render "Couldn't load", not a misleading "Not added").Tests
IntegrationEvidenceTasks.test.tsxandServiceDetailView.test.tsx(4 tests): assert not-added tasks are hidden, the count reflects added-only, no "Not added" text renders, and the error path still shows all rows with a "Couldn't load" notice. All pass..test/auth-clienterrors onmainare unrelated and not in this diff).Follow-up (not in this PR)
The service card in the grid still shows a task-count badge = total mapped tasks, so a card could read "2" while the detail shows "1". Threading the org task templates into the grid would make the card count match — happy to add if wanted.
🤖 Generated with Claude Code
Summary by cubic
Hide evidence tasks that aren’t added to the org in integration views, and make the count badges match what’s visible. On task fetch errors, show all mapped tasks with a “Couldn't load tasks” notice instead of “Not added”.
Written for commit 4ba2447. Summary will update on new commits.