Mariano/policy improvements#251
Merged
Merged
Conversation
…Id, implement SelectAssignee component for better user experience, and enhance form validation
…proved policy management
…of status for archiving logic, enhancing clarity and consistency across components
…d clarity and consistency
… and improve authorization checks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Caution Review failedThe pull request is closed. WalkthroughThis update refactors code formatting and business logic across various modules. Changes include re-indenting files, renaming variables from “owner” to “assignee”, and adjusting policy archiving conditions. Several UI components and pages have been updated to use new components and props, and the database schema has been restructured to drop the owner association in favor of an assignee, along with new fields and foreign key relations. Additional localization keys have been added. Overall, the changes streamline both frontend and backend aspects without modifying core functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant PA as Policy Archive Sheet
participant AP as archivePolicyAction
participant DB as Database
U->>PA: Initiate archive action
PA->>AP: Call archivePolicyAction with policy data
AP->>DB: Update policy (set isArchived = true)
DB-->>AP: Return update result
AP-->>PA: Send success response
PA->>U: Display success message and redirect
sequenceDiagram
participant U as User
participant CP as createPolicyAction
participant MC as Member Check
participant DB as Database
U->>CP: Submit new policy data
CP->>MC: Verify member exists for organization
alt Member exists
MC-->>CP: Return member data (assigneeId)
CP->>DB: Create policy with assigneeId and other details
DB-->>CP: Confirm policy creation
CP-->>U: Return success response
else
CP-->>U: Return error (member not found)
end
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (17)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Refactor
Chores