fix: correct path formatting and destructuring in risk management com…

[carhartlewis]

…ponents

• Fixed path formatting in the redirect for risk registration to remove extra space.
• Updated destructuring of params in the layout component for clarity.
• Ensured consistent usage of riskId in paths across components.
• Removed unused getRisks function implementation from the risk register page for improved readability.

Summary by CodeRabbit

• Bug Fixes

  • Corrected URL formatting in the risk registration redirect.
  • Fixed risk identifier extraction and pagination offset calculation to ensure proper navigation.

• New Features

  • Integrated user data retrieval on the risk page for enriched information display.

• Refactor

  • Modularized risk data retrieval in the risk register, streamlining the underlying logic.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
app	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Mar 21, 2025 8:25pm

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
comp-portal	⬜️ Skipped (Inspect)			Mar 21, 2025 8:25pm

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This diff makes several small but focused changes across risk-related pages. It corrects a URL formatting mistake in a redirect, updates the destructuring of parameters to obtain a risk identifier, and adds a call to retrieve user data. In addition, the arithmetic for pagination in risk data fetching has been fixed for correct operator precedence, and the inline risk-fetch logic has been refactored to an external module. There are no changes to exported entities.

Changes

File(s)	Change Summary
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/(overview)/page.tsx	Removed erroneous space in the redirect URL to correctly format the path as /${session.user.organizationId}/risk/register.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/[riskId]/layout.tsx	Updated risk ID handling by destructuring { riskId } from awaited params and simplified path references from riskId.riskId to riskId.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/[riskId]/page.tsx	Added a call to useUsers() after retrieving the risk object to fetch user data.
apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/register/data/getRisks.ts apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/register/page.tsx	In getRisks.ts, corrected the skip variable calculation with proper parentheses. In the risk register page, removed the inline getRisks function and now import it from an external module.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant R as RiskRegisterPage
    participant G as getRisks Module
    participant DB as Database

    U->>R: Request Risk Register Page
    R->>G: Call getRisks(params)
    G->>DB: Query risk data
    DB-->>G: Return risk data
    G-->>R: Deliver risk data
    R-->>U: Render page with risks

Loading

Possibly related PRs

• chore: update dependencies and refactor authentication redirects in l… #139: Involved similar modifications to redirect URL paths in risk-related components, directly relating to updated redirect logic.
• Refactor Risk Management and RisksByStatus components for improved re… #137: Made comparable formatting adjustments in the RiskManagement function’s redirect, indicating a direct code-level connection.

Poem

I hopped through lines of code today,
Trimming spaces in a playful array.
Risk IDs now shine, crisp and clear,
With users and data drawing near.
A bunny’s leap in logic and flow,
Cheers to refactored code aglow! 🐇
Carrots and clean code forever grow!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3734344 and c5ed5d9.

📒 Files selected for processing (5)

• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/(overview)/page.tsx (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/[riskId]/layout.tsx (2 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/[riskId]/page.tsx (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/register/data/getRisks.ts (1 hunks)
• apps/app/src/app/[locale]/(app)/(dashboard)/[orgId]/risk/register/page.tsx (2 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.