Skip to content

feat(employees): implement editable department for employee details#126

Merged
Marfuen merged 1 commit into
mainfrom
mariano/deel-import
Mar 11, 2025
Merged

feat(employees): implement editable department for employee details#126
Marfuen merged 1 commit into
mainfrom
mariano/deel-import

Conversation

@Marfuen
Copy link
Copy Markdown
Contributor

@Marfuen Marfuen commented Mar 11, 2025

  • Add EditableDepartment component with inline editing functionality
  • Create server action updateEmployeeDepartment for department updates
  • Extend employee details types to support department update schema
  • Update EmployeeDetails to use new editable department component
  • Enhance people table to display department in uppercase

Summary by CodeRabbit

  • New Features

    • Introduced an interactive department editing option in the employee dashboard, allowing inline updates with immediate success and error notifications.
    • Department changes now automatically refresh employee details for up-to-date information.
  • Style

    • Enhanced table presentation: department names are now consistently displayed in uppercase for improved clarity.

- Add `EditableDepartment` component with inline editing functionality
- Create server action `updateEmployeeDepartment` for department updates
- Extend employee details types to support department update schema
- Update `EmployeeDetails` to use new editable department component
- Enhance people table to display department in uppercase
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 6:53pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
comp-portal ⬜️ Skipped (Inspect) Mar 11, 2025 6:53pm
web ⬜️ Skipped (Inspect) Mar 11, 2025 6:53pm

@Marfuen Marfuen merged commit b1b0d37 into main Mar 11, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces a new asynchronous action to update an employee's department with proper authentication and schema validation. It also adds a new React component for inline editing of the department, updating employee details accordingly. Additionally, a new schema and type for the update input have been defined, and a minor styling update has been made to the department column in a data table.

Changes

Files Change Summary
apps/app/src/app/[locale]/.../actions/update-department.ts
apps/app/src/app/[locale]/.../types/index.ts
Introduced a backend asynchronous action for updating an employee's department along with schema validation and type inference for the update input.
apps/app/src/app/[locale]/.../components/EditableDepartment.tsx
apps/app/src/app/[locale]/.../components/EmployeeDetails.tsx
apps/app/src/components/.../data-table.tsx
Added an editable department component integrated into employee details for inline editing, and updated table styling to render department text in uppercase.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant ED as EditableDepartment Component
    participant API as Dept Update Action
    participant DB as Database
    participant RV as Revalidation

    U->>ED: Clicks "Edit" for department
    ED->>API: Call update department action with new value
    API->>DB: Retrieve employee by id & organization
    DB-->>API: Return employee record / error
    API->>DB: Update department if record exists
    API->>RV: Trigger revalidation of related paths
    API-->>ED: Return updated employee data or error
    ED->>U: Display success/error notification
Loading

Possibly Related PRs

  • Improvements #124: Introduced the editable department component that utilizes the new update function, aligning directly with the changes in this PR.

Poem

I'm a coding rabbit, burrowing in code delight,
Hopping through updates that make our app shine bright.
With async actions and schemas set so tight,
Editable components bring changes to light.
A sprinkle of style in each table cell's flight,
Here's to smooth updates, and bytes taking flight! 🐇💻


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4b46a62 and 9d84b45.

📒 Files selected for processing (5)
  • apps/app/src/app/[locale]/(app)/(dashboard)/people/[employeeId]/actions/update-department.ts (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/people/[employeeId]/components/EditableDepartment.tsx (1 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/people/[employeeId]/components/EmployeeDetails.tsx (2 hunks)
  • apps/app/src/app/[locale]/(app)/(dashboard)/people/[employeeId]/types/index.ts (2 hunks)
  • apps/app/src/components/tables/people/data-table.tsx (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot mentioned this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant