Add parsing support for whitespace in macro_rules#297
Open
erickt wants to merge 1 commit into
Open
Conversation
This fixes macro_rules with whitespace between the symbols, like:
```
macro_rules ! macro_with_whitespace {
($ x : expr, $ y : expr) => { $ x + $ y }
}
```
I couldn't find an upstream test that specifically tested for this, but
this syntax is accepted by the [compiler].
[compiler]: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=76adcd8a935e6e9adfef4fbd40ff34a4
|
Hi @erickt, Thanks a lot for this! It looks good to me. Given that contributions to this repository are infrequently reviewed, I have been maintaining a fork of this grammar where I have integrated your changes (some of them were already done, so the diff is smaller). The changes are released on crates.io, PyPI and Codeberg. If you need them to be published elsewhere, let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes macro_rules with whitespace between the symbols, like:
I couldn't find an upstream test that specifically tested for this, but this syntax is accepted by the compiler.