Multi VRGDA via Libraries & Structs#13
Closed
saucepoint wants to merge 33 commits intotransmissions11:masterfrom
saucepoint:master
Closed
Multi VRGDA via Libraries & Structs#13saucepoint wants to merge 33 commits intotransmissions11:masterfrom saucepoint:master
saucepoint wants to merge 33 commits intotransmissions11:masterfrom
saucepoint:master
Conversation
Owner
|
really appreciate the PR! agree there needs to be some changes on the devex of hooking up to multiple VRGDAs. i'm not sure a stateful solution like this is the way to go about it tho, i was more thinking of just abstracting things out into a lib (effectively like how we did it in Monaco) |
Author
|
i see -- will stare at the code a bit more and play around to see how multiple VRGDAs could interact with a lib |
Libraried VRGDA + Support Multi VRGDA
Lib + Struct = OOP
* ✨ LogisticToLinearVRGDA * 📝 Typo * merge in master, remove base files as originally intended * example implementation of a composite VRGDA * conversion of logisticToLinear NFT to use library * contract based logisticToLinear replaced with composite VRGDA in examples * convert mock contract to use library; add fixes to log2lin lib * add 1 wad for log2lin to follow the logistic behavior * snapshot Co-authored-by: t11s <greenfeatherhelp@gmail.com>
Author
|
Letting this marinate a bit, my fork feels a little too opinionated. Gonna close the PR and will likely just maintain a repo for multi VRGDAs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
Creation & usage of multiple VRGDAs occur via structs and libraries.
This offers wonderful ergonomics because the structs and libraries hide all of parameters & math that power the VRGDAs:
Yep! We can have two independent VRGDAs, that rely on different function families, all in the same contract 🤓
MultiNFT.sol)Tangentially relevant gif