S3 Non-multipart location

[kotx]

Initial checklist

• I understand this is a feature request and questions should be posted in the Community Forum
• I searched issues and couldn’t find anything (or linked relevant results below)

Problem

When hooking completeMultipartUpload, you can return a location string to display a link in Dashboard.
https://uppy.io/docs/aws-s3-multipart/#completemultipartuploadfile--uploadid-key-parts-

However, this is not present in getUploadParameters: https://uppy.io/docs/aws-s3-multipart/#getuploadparametersfile-options
(Side note: getUploadParameters doesn't actually pass option, that might be an oversight in the documentation?)

Solution

Allow getUploadParameters to return a location property.

Alternatives

Maybe have a getLocation(key) function in the S3 plugin?

[Murderlon]

Does this fix your issue: #4614?

[kotx]

Does this fix your issue: #4614?

I don't think so. Cloudflare R2 in particular does not return a correct Location header, it returns the region auto for some reason instead.
Also, sometimes the bucket access url is not the same as the internal bucket url. For example when the bucket is accessed behind a firewall.

[Murderlon]

See this issue why we don't support Cloudfare R2 (until they provide a fix on their end): #4505

Closing as duplicate.

[kotx]

See this issue why we don't support Cloudfare R2 (until they provide a fix on their end): #4505

Closing as duplicate.
@Murderlon

Actually both issues (#4514, #4505) are for multipart and not Cloudflare R2-specific, my bad. Non-multipart upload (which is PutObject) does not return a Location header, and shouldn't, from what I can tell from the spec.

In short, the issue is not R2-specific and Uppy should support a location parameter for non-multipart uploads as it does for multipart uploads. Because it is otherwise impossible to return a URL for s3 non-multipart uploads.

[Murderlon]

Doesn't this solve your issue: #4614

There is also a test in it for non multipart uploads.

[kotx]

The Location field doesn't do what I want (it returns a bucket URL that requires authorization, not a public url or custom domain). I like the current API with multipart which allows the server to return a location field that the client can just return to Uppy, which allows for arbitrary URLs.