Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coop setuprebuilds cached Ubuntu 24.04 golden images. Existing instance disks keep their OS.internal_netplanOptionalsetting to builder and fast-start templates, and assert the guest OS version in the macOS integration suite.Closes #616.
Verification
cargo build --workspace,cargo test --workspace,cargo fmt --all -- --check, and workspace Clippy with all targets and features passed.cargo checkand Clippy passed.cargo deny --workspace check,taplo format --check,bash -n tests/integration.sh, and stagedprek runpassed.Integration results
Full integration was run against commit
6eda63f6af49fe6e29c0b0bd5d5cf102b82c2c6don both backends.Linux/Firecracker: passed. The
--fullsuite exited 0 with 613 passed, 0 failed, and 12 expected skips. This included bridge isolation, lifecycle and failure-recovery coverage, model switching, and the credential-injecting proxy phases.macOS/Lima: failed during
setup. The host had Lima 1.0.2. All pre-setup CLI phases passed, but Lima rejected the generated golden-image builder template before creating the VM:The failure exposes a previously undocumented dependency:
internal_netplanOptionaland the corresponding Ubuntu 26.04 cidata/netplan behavior require Lima 2.1.3 or newer. Older Lima releases neither recognize this internal parameter nor contain the associated first-boot NIC-rename workaround, so removing the parameter is not a compatible fallback.Required follow-up before ready for review
The dependency and acceptance criteria are tracked in #616.