Repository navigation
Conversation
hbrodin
reviewed
Oct 6, 2026
| # The chroot inherits the host's PATH. Hosts with a merged sbin (e.g. Arch) | ||
| # omit /usr/sbin and /sbin, where Ubuntu keeps usermod, useradd, ldconfig, etc. | ||
| # that dpkg and package maintainer scripts expect to find. | ||
| export PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin |
Collaborator
There was a problem hiding this comment.
Could you add a regression test that runs the provisioning script with a host PATH lacking /usr/sbin and /sbin, and verifies that usermod is found? The existing setup coverage uses a normal PATH, so it would still pass if this export were removed. Thank you!
Collaborator
There was a problem hiding this comment.
Thanks for contributing! Should've said that the first time around.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ArchLinux
coop setupfails with:as the PATH comes from the system, and
/usr/sbinis not present in all system's default PATH.