Skip to content

Run the OpenSSH forwarding fixture during remote full integration #510

Open

Description

@hbrodin

Problem

./tests/run-integration.sh --remote user@host --full runs the Linux bridge-isolation gate and the full Firecracker VM suite on the remote host, but it does not run tests/integration-proxy-forward.sh there.

The proxy-forward script contains the real-OpenSSH coverage for authenticated reverse forwarding and guest environment transport. Linux CI runs it as a dedicated job, and scripts/preflight-release.sh runs it when preflight itself executes on Linux. However, a release preflight launched from macOS with a remote Linux host only emits a warning for this gate; the subsequent remote --full run still omits it.

Consequently, both VM integration suites can pass without the macOS-driven release workflow automatically enforcing this Linux-only OpenSSH gate.

Proposed change

When tests/run-integration.sh receives both --remote and --full, run tests/integration-proxy-forward.sh from the source archive already copied to the remote Linux host. Treat a failure as a failure of the full integration run, as is already done for tests/integration-network.sh.

Review scripts/preflight-release.sh at the same time so a Linux-local preflight does not needlessly execute the same fixture twice, or document why duplicate execution is intentional.

Acceptance criteria

  • Remote --full runs tests/integration-proxy-forward.sh on the selected Linux host.
  • A fixture failure stops the remote full integration run with a clearly named failing phase.
  • Successful output clearly reports that the real-OpenSSH forwarding gate ran.
  • Remote temporary source and processes are cleaned up on success and failure.
  • macOS local behavior remains explicit: the Linux-only gate is either skipped with a clear message or delegated to the configured remote host.
  • scripts/preflight-release.sh, docs/testing.md, and runner comments describe the same behavior.
  • Existing dedicated Linux CI coverage continues to run.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions