Scrolling issue

[nishantpardamwar]

sorry for opening another issue :D
so the issue is if MultiSelect component is inside a scrollview then ItemSelection windows scroll doesnt work and if i remove the scrollview then if selected items are taking more space than available screen then there is not way to see all the selected items as selected item windows itself is not scrollable

[mitesh-mutha]

Hi, I face a similar issue.

@nishantpardamwar did you find a solution for this?

[toystars]

@nishantpardamwar @mitesh-mutha sorry for the late response. I just updated the component with a new prop fixedHeight which tells the select list to take a fixed height or take the height of all the children in the list. The prop defaults to false, so having the component in a scrollview will push all following components downward in the view so you have access to all items in the list. Setting the prop to true will give a fixed height and should only be used in a view without a need to scroll.

[mitesh-mutha]

Hi, @toystars. Thank you for your response.
Having tested your update. I find that with fixedHeight as false, the submit button disappears at times. It usually (though not always, and also, not limited to) happens when I have already selected few items, then remove some item(s) and then want to select again. At this point, the submit button is not seen.
Let me know if I can provide any additional info for the same.
Can you help me out with this?

[toystars]

@mitesh-mutha can you post your code snippet? So I can try to reproduce... I might be able to catch the reasons for the issue.

[priyanga2496]

Hi, I dont see the full list, because its not fixing within the container

[priyanga2496]

How to make the list fix within the container height in multiple select @toystars

[abdulmoizlakhani]

I also had the same issue. I wanted to give a certain height to multiple select list and also wanted to make it scrollable. Firstly I searched for the solution but did not get the satisfactory solution. At last I tried by giving the height to the View on line 445 of this module. And the result was I got the desired height and also the list was scrollable if the number if list item exceeds to height. But I know that this is not the proper solution. I would suggest the contributors to add the styles prop for the View on line 445 like
<MultiSelect listContainerStyles={styles} />

Thanks.

[AugustoAleGon]

@Abdul-Moiz-Lakhani Can you point me the line on the current code? It has a changed a lot... Thanks in advance.

[abdulmoizlakhani]

@AugustoAleGon

I just installed the package again and found that View on the same line # 445.
Here is that View:

if (canAddItems && !searchTermMatch && searchTerm.length) {
      addItemRow = this._getRowNew({ name: searchTerm });
    }
    component = (
      **_<View>
        {itemList}
        {addItemRow}
      </View>_**
    );
    return component;
  };

[AugustoAleGon]

The package is not updated. I am not able to upload. Try to remove first and apply yarn add https://github.com/toystars/react-native-multiple-select.git

[AugustoAleGon]

so That line is the one that you change and you don't need the fixedHeight property right? @Abdul-Moiz-Lakhani

[abdulmoizlakhani]

Yes, just provided the desired height by inline css to that View.

[AugustoAleGon]

Awesome. Let me upload that change for closing this issue. @Abdul-Moiz-Lakhani . Appreciate your help and quick response.