Repository navigation
fix(truncate): preserve separator boundaries - #2180
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
raon0211
approved these changes
Nov 2, 2026
This was referenced Nov 6, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2172.
Match Lodash when a separator starts exactly at the truncation boundary or at the beginning of the string.
The Lodash calls compile against
@types/lodashwithstrict: true.The same separator is used in the Stratus truncation filter.
Changes
lastIndex.benchmarks/bundle-size/truncate.spec.ts).Bundle size
truncatefromes-toolkit/compat, bundled and minified with esbuild as inbenchmarks/bundle-size:mainThe
escapeRegExpimport is gone, but the boundary check and the loop that finds the last separator (including the step past empty matches) add more code than it saved.lodash-esis 5,354 B.