Repository navigation
docs(trimStart, trim): document error thrown for multi-character string chars - #1936
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
racgoo
pushed a commit
to racgoo/es-toolkit
that referenced
this pull request
Jul 28, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #1931.
trimStartandtrimthrow whencharsis a string whose length is not 1 (validation added in #1615 fortrimStart;trimEndhas the same validation andtrimdelegates to both), but onlytrimEnd's reference docs document this with an#### Errorssection. This adds the missingErrorssections totrimStartandtrim, mirroring the existingtrimEndwording in each language.Changes
#### Errorssection totrimStart.mdandtrim.mdin all four languages (en / ko / ja / zh_hans, 8 files), placed after#### Returnsto match the structure oftrimEnd.mdTest results
trimEnd.mdsections per languageyarn prettier --checkpasses on all touched files