Repository navigation
fix(compat/toPath): keep empty segments for consecutive and trailing dots - #1778
Merged
raon0211 merged 1 commit intoJun 19, 2026
Merged
Conversation
…dots
toPath dropped empty path segments produced by consecutive dots or a
trailing dot, so 'a..b' became ['a', 'b'] instead of lodash's
['a', '', 'b'] and 'a.' became ['a'] instead of ['a', '']. Because
get/set/has/unset/invokeMap parse string paths through toPath, an
empty-string key in the middle of a path ('a..b' on { a: { '': ... } })
was unreachable.
Emit the empty segment when a dot is directly followed by another dot or
the end of the string, and let the leading dot fall through to the main
loop so it is still treated as a separator.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
raon0211
approved these changes
Jun 19, 2026
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compat/toPathdrops empty segments that lodash keeps, so consecutive ortrailing dots resolve differently.
toPath('a..b')returns['a', 'b']instead of lodash's
['a', '', 'b'], andtoPath('a.')returns['a']instead of
['a', ''].Since
get/set/has/unset/invokeMapparse string paths throughtoPath, this makes an empty-string key in the middle of a pathunreachable when migrating from lodash:
Changes
by the end of the string (matching lodash's
stringToPath).as a separator (
'..a'->['', '', 'a']).invokeMap's "string path" test, which asserted the olddivergent result for
'a..c'; lodash invokes through the empty-stringkey, so it now expects that.
Test results
yarn vitest run src/compat— 300 files, 3099 passed, 2 skipped.