Repository navigation
fix(compat/parseInt): coerce input to string before parsing - #1771
Merged
Merged
Conversation
Mirror lodash by routing the input through compat's toString before calling Number.parseInt, so null/undefined become '' (NaN) and symbols return NaN instead of throwing a TypeError.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 task
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While migrating some code from lodash I noticed
compat/parseIntdiverges from lodash on non-string inputs.lodash's
parseIntruns the input through its owntoStringbefore handing it to the nativeparseInt, sonull/undefinedbecome''and symbols stringify instead of crashing. es-toolkit was passing the raw value straight toNumber.parseInt, which relies on native coercion (null→"null", symbols throw).The fix routes the input through the existing
compat/util/toString, matching lodash. Added tests for thenull/undefinedand symbol cases (they fail onmain, pass with the change). Fullcompatsuite,tsc, and lint are green.