Repository navigation
fix(compat/size): count array-like objects by their length - #1766
Merged
Merged
Conversation
`size` returned the number of own enumerable keys for array-like
objects, so `size({ length: 3 })` was 1 instead of 3. lodash treats
array-like values by their `length`, so this diverged.
Route array-like values through `isArrayLike` and return `length`,
matching lodash. Objects whose `length` is not a valid array length
(negative, fractional, non-number, or above MAX_SAFE_INTEGER) still
fall back to the own-key count, as before.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compat/sizereturns the number of own enumerable keys for array-like objects, so it diverges from lodash for values that have a validlengthbut aren't real arrays:lodash's
sizechecksisArrayLike(collection)first and returnscollection.lengthfor array-like values, only falling back to the own-key count for plain objects. es-toolkit skipped that check and went straight toObject.keys(target).length.Fix
Route array-like values through
isArrayLikeand return theirlength, matching lodash. Objects whoselengthis not a valid array length (negative, fractional, non-number, or aboveMAX_SAFE_INTEGER) are still not treated as array-like and fall back to the own-key count, exactly as before — the existingsizetests covering those cases keep passing.Arrays, strings, and
argumentsobjects are unaffected (they were already array-like and produced the same result). Maps and Sets are not array-like, so they still return.size.Tests
Added cases asserting array-like objects are counted by
length. The new tests fail onmainand pass with the fix. The fullsrc/compatsuite (3093 tests),tsc --noEmit, and lint all pass.