Repository navigation
fix(reduce, reduceRight): respect nullish accumulators - #1742
Merged
Merged
Conversation
Match lodash by treating accumulator presence as an argument-count check, so explicit null and undefined initial values are passed to iteratees. Add compat coverage for reduce and reduceRight over arrays and objects.
Add braces to existing single-line early returns so the repository lint command can complete without errors.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
raon0211
marked this pull request as ready for review
May 29, 2026 12:03
raon0211
changed the title
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1741.
es-toolkit/compatnow matches lodash whenreduceorreduceRightreceives an explicitnullorundefinedaccumulator.Changes
arguments.length < 3behavior.nullandundefinedaccumulators across arrays and objects.curlylint errors so the full lint command completes.Test results
mise exec node@24.13.0 -- yarn typecheckmise exec node@24.13.0 -- yarn lintmise exec node@24.13.0 -- yarn vitest run src/compat/array/reduce.spec.ts src/compat/array/reduceRight.spec.tsmise exec node@24.13.0 -- yarn vitest run