Repository navigation
Conversation
Commit f0d40a0 ("odin: make USB transport and flashing async") replaced nusb's blocking .wait() calls with .await. On native targets, nusb implements open(), detach_and_claim_interface(), clear_halt() and friends as blocking syscalls, and awaiting them without the smol or tokio feature panics: Awaiting blocking syscall without an async runtime: enable the `smol` or `tokio` feature of nusb. Enable the smol feature for non-wasm targets so these calls run on the blocking thread pool, which works with any executor including the futures block_on used by the CLI. WebUSB on wasm is unaffected. Assisted-by: Claude:claude-opus-5-5 Signed-off-by: Juhyung Park <qkrwngud825@gmail.com>
Contributor
Author
|
Had this happen to me: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit f0d40a0 ("odin: make USB transport and flashing async") replaced nusb's blocking .wait() calls with .await. On native targets, nusb implements open(), detach_and_claim_interface(), clear_halt() and friends as blocking syscalls, and awaiting them without the smol or tokio feature panics:
Awaiting blocking syscall without an async runtime: enable the
smolortokiofeature of nusb.Enable the smol feature for non-wasm targets so these calls run on the blocking thread pool, which works with any executor including the futures block_on used by the CLI. WebUSB on wasm is unaffected.
Assisted-by: Claude:claude-opus-5-5