Repository navigation
fix(prism): send Muse effort as reasoningEffort - #574
Conversation
|
What: Independent review passes for Reviewed the full Issue #573 including comments, PR description, complete three-file diff from
Nonblocking clarification, PR description and Issue implementation note: the claim that the snapshot does not expose option descriptors is inaccurate. Proof limits: this was a source-only independent review. I ran Requirements and who asked: The user and #573 require the Muse Color effort payload and focused regression, with independent read-only review of the exact head; this supports Drafter delegation toward the Objective. Reviewer model: gpt-6.1-sol. Harness: Codex. Verdict: PASS, no blocking findings. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
What: Prism sends Muse Color effort as
reasoningEffort, with one focused regression test.Why: Muse rejected the fallback
effortoption, preventing configured delegations from starting.So what: Independent review passed on the final head; CI and human merge approval remain separate gates.
Closes #573
Add Muse to the existing static map without changing other provider mappings. Advertised option descriptors can be available under
model.capabilities.optionDescriptors; this microfix retains the existing static map as the smallest correct fix, including when capabilities are absent. The test resolves an easy worker lane using a Muse Color, preserves its model and effort value, and asserts the exact option payload. The feature map links the owning Issue as required by repository policy. No version bump.Proof
pnpm exec vp test run apps/server/src/prism/PrismService.test.ts: 10 passed. Before the production fix, the new regression failed with actualeffortversus expectedreasoningEffort; the other 9 passed.pnpm exec vp lint apps/server/src/prism/PrismService.ts apps/server/src/prism/PrismService.test.ts: passed.pnpm exec vp fmt --check apps/server/src/prism/PrismService.ts apps/server/src/prism/PrismService.test.ts docs/map.md: passed after formatting the new test.pnpm --filter t3 typecheck: passed, with existing Effect suggestions and a Node engine warning (Node 26.8.2; package requests ^24.13.1).git diff --check: passed.The worktree initially lacked dependencies and pnpm on PATH. Used the cached pnpm 11.10.0 executable and
pnpm install --frozen-lockfilein this worktree. No dev server, browser, live provider launch, live userdata access, or repo-wide check. This verifies Prism's selection payload; Independent review passed on7c2c30beba5e90fa9007cc00d36a2a62cb94b5ae: #574 (comment). CI remains a separate gate.Upstream: main has no PrismService path (contents API 404), and open PR/Issue title searches for Prism found no matching fix. Broader Muse effort results concern different paths. Details: #573 (comment).
Surface scope: shared server Prism routing applies to delegated launches from all clients and connection modes. UI entry points, contracts, other provider adapters, reverse states, and user guidance are unchanged. Website/SEO impact: none; no website content or route changes.
Elon record
Requirements and who asked: The user and #573 require Muse Color effort to use
reasoningEffortand one focused PrismService test, restoring Drafter delegation toward the current Objective.Deleted: Dynamic option discovery and changes to other provider mappings are unnecessary.
Bottleneck: The missing Muse case in
effortOptionmakes the existing launch validator reject configured effort.Checked myself: Read the full Issue, inspected the call site, snapshot schema and Muse adapter, observed the regression fail before the map change and all 10 tests pass afterward, and ran the scoped checks above.
Model: gpt-6.1-sol. Harness: Codex.