Repository navigation
chore(fork): remove fork stack commit-count cap - #57
Merged
Merged
Conversation
fork-check.sh failed any PR once the fork stack exceeded 20 commits, an arbitrary limit from PR #9 with no evidence behind it. Main is already at 20 commits, so every fork PR fails the check now. Rebase cost comes from upstream-file edits, which the allowlist and feature map already enforce; the count adds nothing. Drop the --max-commits option and the failure branch, keep the informational "stack: N commit(s)" line and commit list, and update docs/fork.md accordingly. No test asserted the cap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
scripts/fork-check.shfails a PR once the fork stack exceedsMAX_COMMITS=20, a limit chosen arbitrarily in PR #9 with no supporting evidence. Main is already at 20 commits, so every fork PR fails this check now (e.g. PR #56). Rebase cost comes from upstream-file edits, which the same script already enforces through the allowlist and feature map, so the count adds nothing on top.What
scripts/fork-check.sh: remove the--max-commitsoption and the count-exceeds failure branch; keep the informationalstack: N commit(s)line and the commit list.docs/fork.md: drop the "at most 20 commits" bullet from the fork-check description.scripts/fork-maintenance.test.ts), so no test changes needed.Proof
bash scripts/fork-check.sh --base $(git merge-base HEAD origin/main)→fork-check: OK.vitest run scripts/fork-maintenance.test.ts→ 12/12 passed.🤖 Generated with Claude Code