Skip to content

chore(fork): remove fork stack commit-count cap - #57

Merged
lukemaj merged 1 commit into
mainfrom
chore/remove-fork-commit-cap
Sep 28, 2026
Merged

lukemaj merged 1 commit into
mainfrom
chore/remove-fork-commit-cap

Conversation

@lukemaj

@lukemaj lukemaj commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Why

scripts/fork-check.sh fails a PR once the fork stack exceeds MAX_COMMITS=20, a limit chosen arbitrarily in PR #9 with no supporting evidence. Main is already at 20 commits, so every fork PR fails this check now (e.g. PR #56). Rebase cost comes from upstream-file edits, which the same script already enforces through the allowlist and feature map, so the count adds nothing on top.

What

  • scripts/fork-check.sh: remove the --max-commits option and the count-exceeds failure branch; keep the informational stack: N commit(s) line and the commit list.
  • docs/fork.md: drop the "at most 20 commits" bullet from the fork-check description.
  • No merge-commit check or allowlist check changed.
  • No test asserted the removed cap (checked scripts/fork-maintenance.test.ts), so no test changes needed.

Proof

  • bash scripts/fork-check.sh --base $(git merge-base HEAD origin/main) → fork-check: OK.
  • vitest run scripts/fork-maintenance.test.ts → 12/12 passed.

🤖 Generated with Claude Code

fork-check.sh failed any PR once the fork stack exceeded 20 commits,
an arbitrary limit from PR #9 with no evidence behind it. Main is
already at 20 commits, so every fork PR fails the check now.
Rebase cost comes from upstream-file edits, which the allowlist and
feature map already enforce; the count adds nothing.

Drop the --max-commits option and the failure branch, keep the
informational "stack: N commit(s)" line and commit list, and update
docs/fork.md accordingly. No test asserted the cap.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S labels Sep 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider Metric Main baseline This PR Impact PR ceiling
Codex Total thread wire 13.5 KiB 13.5 KiB +7 B (+0.1%) 15.1 KiB ✅
Codex Thread snapshot wire 7.1 KiB 7.1 KiB 0 B (0.0%) 7.3 KiB ✅
Codex Live turn WebSocket wire 6.5 KiB 6.5 KiB +7 B (+0.1%) 7.8 KiB ✅
Codex Live turn WebSocket decoded 56.3 KiB 56.3 KiB 0 B (0.0%) 66.4 KiB ✅
Codex Live turn messages 10 10 0 (0.0%) 21 ✅
Claude Total thread wire 13.5 KiB 13.5 KiB +17 B (+0.1%) 15.1 KiB ✅
Claude Thread snapshot wire 7.1 KiB 7.1 KiB −5 B (−0.1%) 7.3 KiB ✅
Claude Live turn WebSocket wire 6.4 KiB 6.5 KiB +22 B (+0.3%) 7.8 KiB ✅
Claude Live turn WebSocket decoded 57.0 KiB 57.0 KiB 0 B (0.0%) 66.4 KiB ✅
Claude Live turn messages 9 9 0 (0.0%) 21 ✅

Baseline: d11ac07 · PR result: dcf22be · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.9 KiB
  • Claude decoded thread snapshot: 114.6 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant