Repository navigation
fix(grok): request native input echoes for attribution - #351
Conversation
|
What: The Grok runtime never opts in to live user echoes, so #346's extractor receives no root input identity. Read-only bestia evidence on 6408f92: dedicated proof thread completed, durable provider turn stays weak session:turn:1; its isolated native updates.jsonl has root promptIndex 0 with no hidden/synthetic flags. Native archives are not proof of a live wire echo. Bare flavor spreads the normal extractor and uses the same makeGrokAcpRuntime. The transport decoder preserves the actual chunk metadata. The prior three native-promptIndex tests pass because they invoke the adapter callback directly, bypassing initialize negotiation. Grok source 2bdd1d6a6369de0e8c68132ea4539e9abd9e14a8: session/user_echo.rs declares opt-in; agent/mvp_agent/agent_ops.rs resolves it with false default; session/acp_session_impl/updates.rs persists before suppressing live broadcast. Installed binary contains both capability spellings. Chromeria makeGrokAcpRuntime sends clientType extension but no userMessageEcho capability. Upstream search: pingdotgg/t3code PR promptIndex finds only closed #7567; nativeTurnRef issue finds unrelated Pi #13507. Current main e536bfd inspected via source before implementation; no matching repair is being ported. Base: current origin/main 6408f92. Exclusive branch fix/344-grok-root-prompt-index, workspace /home/luke/dev/toolboxmd/chromeria-worktrees/344-grok-root-prompt-index. Main remains read-only with user-owned scripts/pycache/. Objective contribution: authoritative Grok input identities enable Observer evidence for Drafter work and judged Spectrum tests. Requirements and who asked: User requests authoritative root promptIndex persistence for #344, a faithful failing-first test, exact-head Sol and Grok reviews, green CI and merge; no deployment. |
|
What: PR #351 is frozen for independent Sol and Grok review at 1daaffe. Base: 6408f92. Branch fix/344-grok-root-prompt-index; exclusive author workspace /home/luke/dev/toolboxmd/chromeria-worktrees/344-grok-root-prompt-index. Main remains read-only.
Requirements and who asked: User requests a focused #344 Grok repair with exact-head independent Sol/Grok reviews and delegated merge after green CI. |
|
What: Independent Sol review passes on Reviewed exact base Checked independently:
Independent execution used my own archived source and copied dependencies in
Proof limit: these are adapter/wire and static checks, not deployed Grok or Observer attribution acceptance. Repository-wide checks remain CI-owned. No source, Git refs, live database, proof threads, installation or deployment were changed by this review. Reviewed by gpt-6.1-sol at high effort through the Codex harness in T3 Code. |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
|
What: Independent Grok review passes on Reviewed base No required fix. Cleared checks:
Evidence I inspected: author red log shows both new cases failing as weak Reviewed by Grok through the Grok harness in T3 Code. |
* fix(grok): request native input echoes for attribution * test(grok): use branded driver in native ref assertion
What: Grok turns retain the authoritative root input's
promptIndexin normal and bare launches.Why: Grok persists user chunks locally but suppresses their live broadcast unless the client requests
x.ai/userMessageEcho; the adapter never requested it.So what: Merged at a123886 after both independent reviews and green CI; planner owns deployment and Observer95 runtime acceptance.
Refs #344 and toolboxmd/agent-observer#95. This advances trustworthy evidence for Drafter work and judged Spectrum tests.
The shared Grok runtime now declares the live user echo capability during initialization. The existing root-session extractor and native-ref persistence from #346 then work unchanged. Bare isolated homes use the same runtime; file discovery was a separate observation, not the losing adapter boundary. No ordinal inference, transcript lookup, backfill, contract change, version bump or deployment.
Evidence: read-only bestia diagnosis, deployed failure, Observer proof. Grok source declares the opt-in and persists before suppressing broadcast. Current T3 upstream e536bfd also lacks the capability; no matching upstream repair found.
Proof
Base
6408f92bb2af98199567df08c904842733ad28ed; candidate1daaffec10.promptIndex: 0, event metadata and no message id. The peer implements Grok's capability gate. Both normal/user and bare/agent cases fail before the fix with weaknative-root:turn:23, then pass with strongprompt:0and unchanged internal turn identity. Child, hidden and synthetic chunks precede the valid echo.TMPDIR=/home/luke/tmp node_modules/.bin/vp test run apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts -t 'capability-gated root echo|native promptIndex': 5 passed, 123 skipped.git diff --checkpassed.This is adapter wire proof, not deployed acceptance. The two Observer95 proof threads were read-only and remain available for the user's inputs. No UI, transport contract or other harness changes; all clients, agent submissions and scheduled runs share this runtime. No existing feature-map part or user guidance changes. Website and SEO impact: none, backend attribution only.
Elon record
Requirements and who asked: User requests authoritative Grok root input refs for #344, real-shape failing-first proof, independent exact-head Sol/Grok reviews, CI and delegated merge; no deployment.
Deleted: File-history scraping, ordinal guessing, Observer join changes, historical backfill, new component, version bump and deployment.
Bottleneck: The client omitted Grok's live input echo opt-in, so the valid native identity never reached #346's extractor.
Checked myself: Live read-only native event and persisted provider turn, bare runtime wiring, transport decoder, old callback-only test gap, upstream Grok broadcast gate, installed binary capability strings and failing/passing wire regressions.
Implemented by gpt-6.1-sol through the Codex harness in T3 Code.