Repository navigation
Repository creation approval covers delete_branch_on_merge (#137) - #141
Merged
Merged
Conversation
Contributor
Author
|
Independent review (opencode-go/gpt-5.6-luna, variant max, plan mode) of e682d62: APPROVE, no blockers, majors or minors. {"verdict":"APPROVE","blockers":[],"majors":[],"minors":[],"criteria":[{"criterion":"Repository creation approval covers enabling and verifying delete_branch_on_merge=true.","met":true,"evidence":"repository-setup.md:17-19 states this explicitly."},{"criterion":"Existing repositories and every other setting retain the proposed setup and approval bundle.","met":true,"evidence":"repository-setup.md:19-20 preserves the settings authority; the existing approval gate remains at lines 27-29."},{"criterion":"Contract test pins the new wording.","met":true,"evidence":"tests/test_operations_contract.py:240-251 asserts both new sentences and the existing approval gate."},{"criterion":"Non-goals are respected.","met":true,"evidence":"No other approval path changes; the unchanged text at repository-setup.md:23 explicitly excludes stale-branch retirement."},{"criterion":"Wording is consistent with AGENTS.md authority and human gates.","met":true,"evidence":"The wording grants only the already approved repository-creation setting while retaining verification and settings authority for all other cases; AGENTS.md:222-234 and 260-267 are consistent."},{"criterion":"The contract test fails without the new sentences.","met":true,"evidence":"HEAD^ lacks both asserted sentences, while the exact candidate test passes: 55 tests OK."},{"criterion":"Version transition and mirrors are consistent with .version-policy.json.","met":true,"evidence":"VERSION and all four declared mirrors transition 12.4.0 to 12.4.1; CHANGELOG.md has the 12.4.1 entry; release-check passes."},{"criterion":"No em dashes are introduced.","met":true,"evidence":"Changed files and the complete diff contain no em dash characters."},{"criterion":"No unrelated changes are present.","met":true,"evidence":"The exact diff contains only the repository-setup wording, its contract test, required version mirrors, VERSION, and CHANGELOG."}]} |
This was referenced Sep 27, 2026
lukemaj
force-pushed
the
task/137-repo-creation-delete-branch
branch
from
September 27, 2026 17:32
e682d62 to
02fe7e3
Compare
Approval to create a repository now covers enabling and verifying delete_branch_on_merge=true on it without a second settings prompt. Existing repositories and every other setting keep the proposed setup and approval bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lukemaj
force-pushed
the
task/137-repo-creation-delete-branch
branch
from
September 27, 2026 19:12
02fe7e3 to
696505b
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137
repository-setup.md: approval to create a repository covers enabling and verifyingdelete_branch_on_merge=trueon that repository without asking again. Existing repositories and every other setting still use the proposed setup and approval bundle.tests/test_operations_contract.py: pins both sentences and the unchanged approval gate (fails before the doc change, passes after).Proof:
python3 -m unittest discover -s tests -p 'test_*.py': 296 tests OKpython3 -m unittest discover -s tools/versionctl/tests -p 'test_*.py': 6 tests OKtools/versionctl/bin/versionctl release-check: OK v12.4.1🤖 Generated with Claude Code