Skip to content

Repository creation approval covers delete_branch_on_merge (#137) - #141

Merged
lukemaj merged 1 commit into
mainfrom
task/137-repo-creation-delete-branch
Sep 27, 2026
Merged

lukemaj merged 1 commit into
mainfrom
task/137-repo-creation-delete-branch

Conversation

@lukemaj

@lukemaj lukemaj commented Sep 27, 2026

Copy link
Copy Markdown
Contributor

Closes #137

  • repository-setup.md: approval to create a repository covers enabling and verifying delete_branch_on_merge=true on that repository without asking again. Existing repositories and every other setting still use the proposed setup and approval bundle.
  • tests/test_operations_contract.py: pins both sentences and the unchanged approval gate (fails before the doc change, passes after).
  • Version 12.4.0 -> 12.4.1 (patch).

Proof:

  • python3 -m unittest discover -s tests -p 'test_*.py': 296 tests OK
  • python3 -m unittest discover -s tools/versionctl/tests -p 'test_*.py': 6 tests OK
  • tools/versionctl/bin/versionctl release-check: OK v12.4.1

🤖 Generated with Claude Code

@lukemaj

lukemaj commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

Independent review (opencode-go/gpt-5.6-luna, variant max, plan mode) of e682d62: APPROVE, no blockers, majors or minors.

{"verdict":"APPROVE","blockers":[],"majors":[],"minors":[],"criteria":[{"criterion":"Repository creation approval covers enabling and verifying delete_branch_on_merge=true.","met":true,"evidence":"repository-setup.md:17-19 states this explicitly."},{"criterion":"Existing repositories and every other setting retain the proposed setup and approval bundle.","met":true,"evidence":"repository-setup.md:19-20 preserves the settings authority; the existing approval gate remains at lines 27-29."},{"criterion":"Contract test pins the new wording.","met":true,"evidence":"tests/test_operations_contract.py:240-251 asserts both new sentences and the existing approval gate."},{"criterion":"Non-goals are respected.","met":true,"evidence":"No other approval path changes; the unchanged text at repository-setup.md:23 explicitly excludes stale-branch retirement."},{"criterion":"Wording is consistent with AGENTS.md authority and human gates.","met":true,"evidence":"The wording grants only the already approved repository-creation setting while retaining verification and settings authority for all other cases; AGENTS.md:222-234 and 260-267 are consistent."},{"criterion":"The contract test fails without the new sentences.","met":true,"evidence":"HEAD^ lacks both asserted sentences, while the exact candidate test passes: 55 tests OK."},{"criterion":"Version transition and mirrors are consistent with .version-policy.json.","met":true,"evidence":"VERSION and all four declared mirrors transition 12.4.0 to 12.4.1; CHANGELOG.md has the 12.4.1 entry; release-check passes."},{"criterion":"No em dashes are introduced.","met":true,"evidence":"Changed files and the complete diff contain no em dash characters."},{"criterion":"No unrelated changes are present.","met":true,"evidence":"The exact diff contains only the repository-setup wording, its contract test, required version mirrors, VERSION, and CHANGELOG."}]}

Approval to create a repository now covers enabling and verifying
delete_branch_on_merge=true on it without a second settings prompt.
Existing repositories and every other setting keep the proposed setup
and approval bundle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lukemaj
lukemaj force-pushed the task/137-repo-creation-delete-branch branch from 02fe7e3 to 696505b Compare September 27, 2026 19:12
@lukemaj

lukemaj commented Sep 27, 2026

Copy link
Copy Markdown
Contributor Author

Independent check of the rebase to 696505b (coordinator): content approved at e682d62 (Luna max, no findings); range-diff shows only the 13.0.1 bump and changelog header. Verdict: approve.

@lukemaj
lukemaj merged commit ef1b3f5 into main Sep 27, 2026
3 checks passed
@lukemaj
lukemaj deleted the task/137-repo-creation-delete-branch branch September 27, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Repository creation approval covers delete_branch_on_merge

1 participant