Skip to content

Final-review fixes: skill targets, identity sanitizing, semantic-aware reports - #19

Merged
lukemaj merged 3 commits into
integration/mac-observerfrom
task/1-final-fixes
Sep 24, 2026
Merged

lukemaj merged 3 commits into
integration/mac-observerfrom
task/1-final-fixes

Conversation

@lukemaj

@lukemaj lukemaj commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Component PR into integration/mac-observer: resolves the final review of the 0.2.0 candidate.

  • Skill targets hold only the validated skill identifier in every adapter (paths only in detail); target filtering is family-aware in every shared writer.
  • Instruction identity is validated (closed direction status set as the AgentsMD loader emits, fixed-length hashes, typed paths) and only allowlisted fields are serialized; a privacy-version re-import replaces every source-owned identity field, centralized in the ledger layer and covering multi-source sessions.
  • Reports, publish, sessions and compare never add raw counters across different counter semantics.
  • agent_observer.__version__ follows VERSION; publish --dry-run --json returns JSON.

Refs #1, #3, #4.

Proof

Candidate b395677 on integration a0280be: python3 -m unittest discover -s tests 332 tests OK.

Review

Independent Luna reviews over three rounds through Model Router jobs ao-final-fix-1 to ao-final-fix-3 (two dispatcher replies were malformed, toolboxmd/model-router#77); the combined review of a0280be..b395677: APPROVE, no findings.

🤖 Generated with Claude Code

lukemaj and others added 3 commits September 24, 2026 07:52
…s totals, version from VERSION, publish dry-run JSON (#1)

Addresses the final review of 7098846 through Model Router job ao-final-fix-1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-import, semantic-aware reports, full direction status set (#1)

Worker turn of Model Router job ao-final-fix-2 (the dispatcher's follow-up
reply was malformed, toolboxmd/model-router#77).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…linked source; adapters change only skill targets (#1)

Implemented through Model Router job ao-final-fix-3.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lukemaj
lukemaj merged commit 4cf2976 into integration/mac-observer Sep 24, 2026
1 check passed
@lukemaj
lukemaj deleted the task/1-final-fixes branch September 24, 2026 06:45
lukemaj added a commit that referenced this pull request Sep 24, 2026
…ode, OpenCode, Grok Build and Model Router

One private SQLite ledger of the records these tools already keep on this
Mac: usage per response with each harness's own counter meaning, timelines,
behavior detectors, comparison by AgentsMD version, model, harness and
project, session visibility, and one marker-owned GitHub summary on explicit
command. agent_observer/privacy.py enforces the ledger privacy rules for
every writer. Delivered through component PRs #10 to #19, each reviewed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lukemaj lukemaj mentioned this pull request Sep 24, 2026
lukemaj added a commit that referenced this pull request Sep 24, 2026
One private SQLite ledger of the records these tools already keep on this
Mac: usage per response with each harness's own counter meaning, timelines,
behavior detectors, comparison by AgentsMD version, model, harness and
project, session visibility, and one marker-owned GitHub summary on explicit
command. agent_observer/privacy.py enforces the ledger privacy rules for
every writer. Delivered through component PRs #10 to #19, each reviewed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant