Repository navigation
fix(claude): recognize native request-replay metadata - #113
Conversation
|
What: Independent review passes for exact head Reviewed base Independently executed on this exact head:
Proof limits: the author's PR record reports 787 full-suite tests passing and compileall passing on this head. I inspected that record, not the underlying full-suite/compileall output, and did not duplicate those checks. Failing-before results for all three known types are author-supplied, not independently rerun. My runtime proof uses synthetic records and disposable test ledgers only; no native mock-API transcript, recording activation, live-ledger mutation or deployment was exercised. Previously stored quarantine errors are not migrated, as already documented in this PR. This verdict covers the inspected implementation, not completion of CI or permission to merge. |
|
Luna review r1 of 1d2bf5f: APPROVE No blocking or optional findings. Verified the exact head and base. The diff adds exactly the three requested metadata types; other unknown types still reach Proof: |
What: Recognize Claude's three native request-replay record types as known metadata.
Why: They currently fall through the Claude adapter dispatch and create unsupported-schema import errors.
So what: The coordinator can review and merge this fix, then include it in the separate release PR.
Closes #87
Changes
api-request,api-request-blobandapi-request-shapetoIGNORED_METADATA_TYPES.api-request-futureas an unknown type.Proof
Candidate:
1d2bf5f7a90b215e6a127fa082aa3e36a3bdbb4b, base:71bcb597a3ec8a15f3c595d043fc07d0e2271b59.malformed=1instead of0.python3 -m unittest tests.test_claude: PASS, 11 tests on this head.python3 -m unittest discover -s tests: PASS, 787 tests in 174.088 seconds on this head.python3 -m compileall -q agent_observer tests scripts: PASS on this head.git diff --check HEAD: PASS; worktree clean.review/independent=successverified on this head.Limits
Synthetic import proof only; no live recording activation, deployment or native mock-API transcript corroboration. Existing unsupported-schema errors in previously imported ledgers are not migrated. Version, manifests and changelog intentionally deferred to the coordinator's release PR per task instructions. Website impact: none, internal adapter metadata compatibility only. Full-suite output includes ResourceWarnings for unclosed resources in fleet and publish tests; no unrelated changes made. Cost publication with the installed Agent Observer plugin against a disposable read-only-sourced ledger copy exited 2:
nothing to publish: no sessions in scope. No live ledger writes or sync were performed.Elon record
Requirements and who asked: Issue #87 and the implementation brief require explicit recognition of three native metadata types, private payload handling, unchanged accounting and quarantine of unknown types; this supports trustworthy native coverage in the Objective.
Deleted: Payload parsing/storage, blanket ignoring of future types, recording activation, release/version changes and cross-project work.
Bottleneck: Three missing allowlist entries cause known native metadata to enter unsupported-schema quarantine.
Checked myself: Read Issue #87 and adapter dispatch; reproduced all three failures before the three-entry fix; inspected full-ledger privacy and unchanged accounting assertions with synthetic records.
Implemented with Codex (GPT-6.1).