You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Use @aws-sdk/client-s3, @aws-sdk/s3-request-presigner packages instead of aws-sdk #9
Hello, thanks for the lovely library. I haven't implemented it yet but was surprised to find the entire aws-sdk being pulled in. Surely the s3 packages would be enough no?
changed the title [-]Use @aws-sdk/client-s3/@aws-sdk/s3-request-presigner packages instead of aws-sdk[/-][+]Use @aws-sdk/client-s3, @aws-sdk/s3-request-presigner packages instead of aws-sdk[/+]on Nov 3, 2022
@mvandoff Sure thing, you can make a proposal PR, best would be to have these as two separated PRs so one doesn't block the other. This is just in case, as if everything looks good, I'll merge both.
Only recommendation to male things smooth: only add optional parameters on top of the existing API and use strong types.
Activity
[-]Use @aws-sdk/client-s3/@aws-sdk/s3-request-presigner packages instead of aws-sdk[/-][+]Use @aws-sdk/client-s3, @aws-sdk/s3-request-presigner packages instead of aws-sdk[/+]toniopelo commentedon Nov 4, 2022
I guess you're right @mvandoff, this is a good point. Would you be willing to create a PR ? :)
mvandoff commentedon Nov 5, 2022
Life is hectic right now but I'll look into it.
mvandoff commentedon Nov 5, 2022
@toniopelo I need to be able to add metadata to the uploads, can I add support for that while I'm at it?
toniopelo commentedon Nov 5, 2022
@mvandoff Sure thing, you can make a proposal PR, best would be to have these as two separated PRs so one doesn't block the other. This is just in case, as if everything looks good, I'll merge both.
Only recommendation to male things smooth: only add optional parameters on top of the existing API and use strong types.