Skip to content

Add repeat to spinners when holding down mouse - #651

Merged
tom5454 merged 4 commits into
tom5454:masterfrom
Psychpsyo:SpinnerMouseRepeat
Aug 27, 2024
Merged

tom5454 merged 4 commits into
tom5454:masterfrom
Psychpsyo:SpinnerMouseRepeat

Conversation

@Psychpsyo

Copy link
Copy Markdown
Contributor

This implements this suggestion from the discord:
image
https://discord.com/channels/811508670205788211/829768829542334544/1269740342517698690

I've implemented it in a way where the longer you hold down the mouse button, the faster it goes so that it gives fine-ish control over small adjustments while still allowing you to quickly go larger distances.

I hope just opening PRs like this is fine. (and if it is, I might do more in the future)
If not, I'm sorry.

@tom5454 tom5454 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't compile on all platforms. You can't use java.util.Timer.

Store the mouse down state and update the value under the draw method.

@Psychpsyo

Copy link
Copy Markdown
Contributor Author

This won't compile on all platforms. You can't use java.util.Timer.

Store the mouse down state and update the value under the draw method.

Done.
I've also made it so that the repeat doesn't need to ramp up to full speed anymore.
It just kicks in at full speed after about half a second since that felt better to use.

@Psychpsyo
Psychpsyo requested a review from tom5454 August 7, 2024 17:14
@Psychpsyo
Psychpsyo requested a review from tom5454 August 10, 2024 19:35

@tom5454 tom5454 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@tom5454
tom5454 merged commit 4ef23d3 into tom5454:master Aug 27, 2024
tom5454 added a commit that referenced this pull request Aug 27, 2024
Added all of the options to non-experimental exports
Added a hidden from gesture gui (useful for animations with /cpmclient)
Added repeat to spinners when holding down mouse (#651)
Fixed command activated animations showing up with /cpmclient animate
Extruded cubes now count to cube count for safety settings (3/4 of a cube)
Increased max data block size in exported models to 16 MB (fixed large textures breaking without any info)
Fixed dropdown box not working with older exported models
Fixed dropdown box default value not loading
Fixed player head items not showing
tom5454 added a commit that referenced this pull request Sep 1, 2024
Added animation must finish option to animations (#486)
Added value layer interpolated setting, improved value layer interpolations
Added max value setting to value layers (sliders snap in gesture gui now)
Added repeat to spinners when holding down mouse (#651)
Added a hidden from gesture gui (useful for animations with /cpmclient)
Drop Down menus and toggle layers use the available parameter space more efficiently (experimental export only) (Closes #608)
Increased max data block size in exported models to 16 MB
Extruded cubes now count to cube count for safety settings (3/4 of a cube)
The Show Names toggle is now saved
Editor QoL:
- Shift+Add Frame adds an empty frame
- Added clear frame button to animation dropdown
- Animation Data paste won't clear the clipboard
- New Animation Frame keybind
- Added Make Armor and Make 2nd layer to Edit/Tools
- Added an indicator to light level animation in the editor
- Added an Invert Camera Y option to settings

Updated to BTA 7.2-pre2
Ported to Quilt 1.21, Fabric 24w35a
Updated Spanish translations (#625)
Added Brazilian Portuguese translations (#624)
Updated Simplified Chinese translations (#623, #649)
Fixed crash when opening the config screen from the modlist on NeoForge 1.21
Fixed player head items not showing on 1.20.6+
Fixed wiki sidebar not loading the localized variant
Fixed open wiki tooltip not opening the localized variant
Fixed Export Update allowing incompatible update exports
Fixed finish animations breaking with value poses (Closes #647)
Fixed gui animation jittering on NeoForge 1.21

BB:
Fixed null objects breaking the animator in BlockBench with the plugin installed (Closes #643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants