Environmental changes are now optional#369
Merged
Merged
Conversation
Owner
|
Thank you @Robin-K-Lynn ! I confirmed that the icon.color change does not break anything on macos. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
os.envion[] assignments now have a check before them so they are disabled automatically if the system/user has already set a default or an override.
I added
icon.color: undefinedas all themes other than Fusion treat icon sources as a colour mask if this parameter is not set. Please test this to see if it breaks anything on other OSes. Another way of keeping the colours would be to wrap the images in an Image{}.Running the command
QT_QUICK_CONTROLS_STYLE="Universal" ./main.pyfor example changes the style to "Universal"