Include additional files in setuptools package#196
Merged
tlecomte merged 1 commit intoSep 30, 2021
Conversation
12 tasks
Owner
|
Thank you very much @alyaeanyx ! |
Contributor
Author
|
Thanks for merging! Quick question - are you planning to do a "follow-up release" for this fix or should I backport this change for NixOS? |
Owner
I received a report of failures to start the appImage on Linux (unrelated to this PR), so I'd like to test this first, and then I'll do a release. Hopefully this should be quick! |
Contributor
Author
|
Cool, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a couple of additional files from the QML changes in the Python package generated by setuptools. The fact that they were missing caused problem's with the packaging mechanism of my Linux distro (NixOS) as it is based on running
python setup.py install, and will likely also cause issues with other distros such as with the friture AUR package from Arch Linux.