convert string to array ie7 workarround#80
Closed
jfromaniello wants to merge 0 commit intotj:masterfrom
Closed
Conversation
Collaborator
|
Thanks, I am going to test that in old IEs and merge if it works. But LGTM in general. |
Author
|
Did you tested? I'm using this in very big project in production since I made the pull request. I'd like to point to the official release. Thanks in advance |
Author
|
I updated into a new pull request. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workarround for IE7 where strings can't be used as arrays directly.