git-style subcommands mess up argument order when using boolean flags

index.js

var command = require('commander')

var cmd = command
  .command('hello', 'description')
  .parse(process.argv)

index-hello.js

var command = require('commander')

var cmd = command
  .option('--dry-run', 'prints actions, but takes none')
  .parse(process.argv)

console.log('opts', cmd.opts())
console.log('args', cmd.args)

output

$ node index.js hello 1 2 --dry-run 3 4 5 6
opts { dryRun: true }
args [ '1', '2', '4', '5', '6', '3' ]

Note how 3 has been shifted to the end. This really messes with you when working with subcommands that expect a specific argument ordering.

Found and tested against commander@2.9.0

Ran into the same problem just now.

I can confirm this issue as well.

I can confirm this issue on commander@2.18.0 as well.

This was reported again in #962 which has some good reproduction examples and discussion.

Possible related, reported for action handler: #56 #75

Reproduced related issue with action handler:

const program = require('commander');

program
  .command('sub <args...>')
  .option('-a')
  .action((args) => {
    console.log(args);
  })

program
  .parse(process.argv);

$ node badParse.js sub foo bar
[ 'foo', 'bar' ]
$ node badParse.js sub -a foo bar
[ 'foo', 'bar' ]
$ node badParse.js sub foo -a bar
[ 'bar', 'foo' ]

Opened a PR to preserve argument order: #1138

The argument order is fixed in the published pre-release of Commander v5.0.0 (#1163)

Commander v5.0.0 has been released.

https://github.com/tj/commander.js/releases/tag/v5.0.0

fix(package): update commander to version 5.0.0

Navigation Menu

Repository navigation

git-style subcommands mess up argument order when using boolean flags #508

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

git-style subcommands mess up argument order when using boolean flags #508

Description

Activity

jmatsushita commented on Mar 13, 2016

nukelytide commented on Mar 14, 2017

stnever commented on Feb 20, 2019

shadowspawn commented on Aug 10, 2019

shadowspawn commented on Dec 29, 2019

shadowspawn commented on Dec 29, 2019

shadowspawn commented on Jan 7, 2020

shadowspawn commented on Feb 1, 2020

shadowspawn commented on Mar 14, 2020

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions