size: fix empty struct collection expressions - #452
Merged
philhofer merged 1 commit intoSep 21, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collections of empty structs using the default map encoding currently produce invalid
Msgsizeexpressions such aslen(z.Named) * (1 + ), causing the generator to fail formatting otherwise valid Go input. Return the encoded header size alone when a struct has no field-size terms.The regression generates and executes code for named and anonymous empty-struct slices and fixed, zero-length, and nested arrays. It checks the size bound and byte/stream round trips.
Fixes #101.
Validation:
_generated, pass on Go 1.24.13 and pass with-raceon Go 1.26.6.-raceon Go 1.24.13, 1.25.13, and 1.26.6.make prepare, formatting, and golangci-lint 2.9.0 pass.Local validation ran on macOS arm64. TinyGo was unavailable, so
tinygotestwas not run. The available lint version was 2.9.0 rather than CI's pinned 2.5.0.