Allow ignore directives to contain regex - #423
Merged
Merged
Conversation
Prefixing name of a an ignore directive with `regex:` will make it ignore all regex matches.
philhofer
reviewed
Nov 20, 2025
Co-authored-by: Phil <philhofer@users.noreply.github.com>
philhofer
self-requested a review
November 20, 2025 21:12
philhofer
approved these changes
Nov 20, 2025
6 tasks
gannett-ggreer
pushed a commit
to GannettDigital/msgp
that referenced
this pull request
Aug 25, 2026
Prefixing name of a an ignore directive with `regex:` will make it ignore all RE2 regex matches. Examples: ``` //msgp:ignore regex:IGNORE ``` Ignore all types that contains `IGNORE`. ``` //msgp:size ignore regex:IGNORE ``` Do not generate `Msgsize() int` for all types that contains IGNORE. Co-authored-by: Phil <philhofer@users.noreply.github.com> --------- Co-authored-by: Phil <philhofer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefixing name of a an ignore directive with
regex:will make it ignore all RE2 regex matches.Examples:
Ignore all types that contains
IGNORE.Do not generate
Msgsize() intfor all types that contains IGNORE.