Add "setof" helpers - #408
Merged
Merged
Conversation
* Add `FooFromSlice` that will convert a slice of type to map[foo]struct{}
* Add `Foo.AsSlice` that will return the set as a slice (sorted on sorted types).
* Use `clear` to clear maps (Go 1.21)
We can't use fancy `maps` and `slices` methods yet, since that is Go 1.23.
philhofer
approved these changes
Aug 29, 2025
6 tasks
gannett-ggreer
pushed a commit
to GannettDigital/msgp
that referenced
this pull request
Aug 25, 2026
* Add `FooFromSlice` that will convert a slice of type to map[foo]struct{}
* Add `Foo.AsSlice` that will return the set as a slice (sorted on sorted types).
* Use `clear` to clear maps (Go 1.21)
We can't use fancy `maps` and `slices` methods yet, since that is Go 1.23.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FooFromSlicethat will convert a slice of type to map[foo]struct{}Foo.AsSlicethat will return the set as a slice (sorted on sorted types).clearto clear maps (Go 1.21)We can't use fancy
mapsandslicesmethods yet, since that is Go 1.23.