fix(app): reload webview instead of restart_app in dev mode (#1068)

[oxoxDev]

Summary

• Replace Tauri app.restart() with window.location.reload() in pnpm dev:app so the dev session survives an identity flip / restart trigger.
• Packaged builds keep the original app.restart() path; no behaviour change there.
• Add Vitest coverage for the dev (reload) and prod (invoke('restart_app')) branches in restartApp.

Problem

pnpm dev:app runs pnpm tauri dev -> cargo run -> tauri-cef CLI -> vite (child). When restartApp() invokes Tauri's app.restart(), the cargo parent exits and orphans the vite child, killing the entire dev session — the desktop window disappears and the user has to re-run pnpm dev:app by hand.

The dominant caller is the identity-flip path in app/src/providers/CoreStateProvider.tsx, which fires automatically when persisted OPENHUMAN_ACTIVE_USER_ID differs from the bootstrap snapshot's auth.userId (e.g. after switching profiles in the UI). This made dev-mode profile switching effectively unusable.

Solution

Gate at the source — restartApp() in app/src/utils/tauriCommands/core.ts:

• In dev mode (IS_DEV from app/src/utils/config.ts), call window.location.reload(). Module init re-runs, so the freshly-set OPENHUMAN_ACTIVE_USER_ID localStorage seed (already updated by setActiveUserId upstream of restartApp) is read at boot, redux-persist re-hydrates from the new user's namespace, and singleton services come up clean — without touching the cargo / vite processes.
• In production mode, keep the original app.restart() invocation. There is no vite child to orphan, and the existing CEF profile-path machinery still needs the full process restart.

Gating at the source means every current and future caller benefits without per-call-site changes. IS_DEV is the canonical re-export from app/src/utils/config.ts, per the project's "no import.meta.env outside config.ts" rule.

Submission Checklist

If a section does not apply to this change, mark the item as N/A with a one-line reason. Do not delete items.

• Tests added or updated (happy path + at least one failure / edge case) per docs/TESTING-STRATEGY.md
• N/A: behaviour-only — no matrix rows touched. Coverage matrix not affected; existing restartApp row still describes the user-visible contract.
• N/A: behaviour-only — no new feature IDs. Listed under ## Related below.
• No new external network dependencies introduced (mock backend used per docs/TESTING-STRATEGY.md)
• N/A: dev-only path — release-cut surfaces unchanged; app.restart() continues to run in packaged builds, which is what RELEASE-MANUAL-SMOKE.md covers.
• Linked issue closed via Closes #NNN in the ## Related section

Impact

• Runtime: Desktop dev (pnpm dev:app) only. Packaged macOS/Windows/Linux builds keep app.restart() unchanged.
• Performance: Dev reload is faster than the previous (broken) full process restart and avoids the manual re-launch cost.
• Security: None — same trust boundary; the reload still re-runs the bootstrap/auth chain.
• Migration: None.
• Compatibility: All current restartApp() callers (identity flip, CEF profile rotation, post-update relaunch in dev) get the new behaviour automatically. Production semantics are byte-identical.

Related

• Closes [Bug] dev:app restartApp() kills vite parent → entire dev session exits #1068
• Surfaced while smoke-testing fix(welcome): re-enable OAuth buttons with focus/timeout recovery (#1049) #1069 (the OAuth re-enable PR) in pnpm dev:app. Independent of fix(welcome): re-enable OAuth buttons with focus/timeout recovery (#1049) #1069 — the bug exists on main regardless of OAuth state.

Summary by CodeRabbit

• Bug Fixes
  • Improved app restart functionality with enhanced runtime environment detection for more reliable restart behavior across different deployment scenarios.

[coderabbitai]

📝 Walkthrough

Walkthrough

The restartApp() function now conditionally uses window.location.reload() in dev mode instead of invoking Tauri's app.restart(), preventing the termination of the development vite process. Corresponding tests were added to verify both dev and production behavior.

Changes

Cohort / File(s)	Summary
Dev Mode Restart Logic app/src/utils/tauriCommands/core.ts, app/src/utils/tauriCommands/core.test.ts	restartApp() now branches on IS_DEV: dev mode calls window.location.reload() and returns early, while production mode invokes invoke<void>('restart_app'). Tests mock window.location, verify reload is never called outside Tauri, and include separate test cases for dev (reload called once, invoke uncalled) and production (invoke called, reload uncalled) modes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A reload in dev, a restart in prod,
No more vite orphans when we restart our code!
The dev session thrives while we build and we test,
Window's gentle refresh puts the module at rest. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: replacing Tauri app.restart() with window.location.reload() in dev mode, which directly aligns with the changeset modifying restartApp() behavior.
Linked Issues check	✅ Passed	The PR fully addresses issue #1068 requirements: uses window.location.reload() in dev mode, preserves app.restart() for production, applies gating at restartApp() source, adds tests covering both branches, and closes the linked issue.
Out of Scope Changes check	✅ Passed	All changes are scoped to the restartApp() implementation and its tests. No unrelated modifications to other systems, APIs, or functionalities were introduced outside the dev mode reload fix.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 3/5 reviews remaining, refill in 21 minutes and 2 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

app/src/utils/tauriCommands/core.test.ts (1)

75-84: ⚡ Quick win

IS_DEV=false factory mock pattern is likely brittle in this repo’s jsdom setup

This file combines module-level mocks with vi.doMock('../config') + vi.resetModules(), which has previously broken jsdom setup here. Consider replacing this with a less fragile strategy (e.g., testing an extracted mode-param helper, or validating prod behavior outside this jsdom path).

Based on learnings: In tinyhumansai/openhuman, testing IS_DEV=false via a factory mock of ../../utils/config breaks the jsdom environment setup chain in files with module-level mocks.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@app/src/utils/tauriCommands/core.test.ts` around lines 75 - 84, The test uses
a brittle pattern (vi.doMock('../config') + vi.resetModules()) to force
IS_DEV=false before importing ./core; replace this with a less fragile approach:
either extract the environment-dependent logic into a helper function you can
call with an explicit mode (e.g., create a getMode or isDev param and test that
function directly) or set the config value via a stable DI/override mechanism
before importing (for example use vi.mock('../config', () => ({ IS_DEV: false,
...vi.importActual('../config') })) without resetModules or refactor core to
accept a mode param so the test can import ./core normally and call the
production path explicitly instead of relying on module-level re-mocking; update
the test named "invokes restart_app in production mode (IS_DEV=false)" to use
the new helper/DI approach and remove vi.doMock + vi.resetModules usage and the
fragile factory mock of IS_DEV.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@app/src/utils/tauriCommands/core.test.ts`:
- Around line 75-84: The test uses a brittle pattern (vi.doMock('../config') +
vi.resetModules()) to force IS_DEV=false before importing ./core; replace this
with a less fragile approach: either extract the environment-dependent logic
into a helper function you can call with an explicit mode (e.g., create a
getMode or isDev param and test that function directly) or set the config value
via a stable DI/override mechanism before importing (for example use
vi.mock('../config', () => ({ IS_DEV: false, ...vi.importActual('../config') }))
without resetModules or refactor core to accept a mode param so the test can
import ./core normally and call the production path explicitly instead of
relying on module-level re-mocking; update the test named "invokes restart_app
in production mode (IS_DEV=false)" to use the new helper/DI approach and remove
vi.doMock + vi.resetModules usage and the fragile factory mock of IS_DEV.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e311940d-59ec-42f1-baff-6cfd4c451434

📥 Commits

Reviewing files that changed from the base of the PR and between 6ac7885 and 9e0d3f6.

📒 Files selected for processing (2)

• app/src/utils/tauriCommands/core.test.ts
• app/src/utils/tauriCommands/core.ts