[close #663] Select TiFlash Stores Round-Robin#662
Merged
iosmanthus merged 8 commits intotikv:masterfrom Nov 1, 2022
Merged
Conversation
Signed-off-by: shiyuhang <1136742008@qq.com>
595af7d to
5f80236
Compare
Codecov ReportBase: 34.81% // Head: 35.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #662 +/- ##
============================================
+ Coverage 34.81% 35.06% +0.25%
- Complexity 1433 1446 +13
============================================
Files 278 278
Lines 17377 17380 +3
Branches 1974 1975 +1
============================================
+ Hits 6049 6095 +46
+ Misses 10715 10666 -49
- Partials 613 619 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
iosmanthus
reviewed
Oct 31, 2022
iosmanthus
reviewed
Oct 31, 2022
Signed-off-by: shiyuhang <1136742008@qq.com>
zhangyangyu
previously approved these changes
Oct 31, 2022
Collaborator
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
Member
|
LGTM |
Signed-off-by: shiyuhang <1136742008@qq.com>
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Dec 20, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.3 in PR #688 |
zhangyangyu
pushed a commit
that referenced
this pull request
Dec 20, 2022
iosmanthus
pushed a commit
to iosmanthus/client-java
that referenced
this pull request
Dec 30, 2022
shiyuhang0
pushed a commit
to shiyuhang0/client-java
that referenced
this pull request
Dec 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Description: client-java always selects the first TiFlash store which may cause read hotspot.
What is changed and how does it work?
Choose the TiFlash stores Round-Robin
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes