[fix #623] region may be missed (#624)#625
Merged
iosmanthus merged 1 commit intotikv:release-3.3from Jun 30, 2022
Merged
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
Author
|
/run-all-tests |
zhangyangyu
approved these changes
Jun 30, 2022
Collaborator
Author
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
Codecov Report
@@ Coverage Diff @@
## release-3.3 #625 +/- ##
==============================================
Coverage ? 34.67%
Complexity ? 1423
==============================================
Files ? 278
Lines ? 17358
Branches ? 1972
==============================================
Hits ? 6019
Misses ? 10736
Partials ? 603 Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #624 to release-3.3
You can switch your code base to this Pull Request by using git-extras:
# In client-java repo: git pr https://github.com/tikv/client-java/pull/625After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #623
Problem Description: If there is a region split between two queries, it may miss some regions.
What is changed and how does it work?
I change the time of getting region from before scan to after scan.
When we build client, we will use region info in regionCache. After region split, it's outdated.
But when client try to scan the region, it will get the newest region info from pb.
In the original code, we get region info before scan. So the region info is still outdated and it will use the old endKey to get next region. Using the old endKey may miss some regions that split during the two query.
I get the region info after scan to make sure the return value is newest.
Check List for Tests
This PR has been tested by at least one of the following methods: