[close #619] Shutdown recycler when closing ChannelFactory to avoid resource leak#618
Conversation
Signed-off-by: Daemonxiao <735462752@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
============================================
- Coverage 34.72% 34.67% -0.06%
+ Complexity 1425 1423 -2
============================================
Files 278 278
Lines 17354 17356 +2
Branches 1972 1972
============================================
- Hits 6027 6018 -9
- Misses 10713 10735 +22
+ Partials 614 603 -11
Continue to review full report at Codecov.
|
|
@Daemonxiao Could you create an issue with this pull request? The PR title checker will check if the PR is related to an issue. |
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
|
The tests for |
|
/hold |
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.3 in PR #621 |
Signed-off-by: Daemonxiao 735462752@qq.com
What problem does this PR solve?
Issue Number: close #619
Because the
recyclerinChannelFactorydoes not set any task when TLS is turned off, the process will get stuck on exit.What is changed and how does it work?
When we don't use TLS,
recyclershould benull.Code changes
Side effects
Related changes