fix TLS reload doesn't work after delete cert file#609
Merged
iosmanthus merged 6 commits intotikv:masterfrom Jun 14, 2022
Merged
fix TLS reload doesn't work after delete cert file#609iosmanthus merged 6 commits intotikv:masterfrom
iosmanthus merged 6 commits intotikv:masterfrom
Conversation
Signed-off-by: Daemonxiao <735462752@qq.com>
Codecov Report
@@ Coverage Diff @@
## master #609 +/- ##
============================================
+ Coverage 34.60% 34.63% +0.02%
+ Complexity 1418 1416 -2
============================================
Files 278 278
Lines 17342 17352 +10
Branches 1970 1971 +1
============================================
+ Hits 6002 6009 +7
Misses 10732 10732
- Partials 608 611 +3
Continue to review full report at Codecov.
|
sunxiaoguang
previously approved these changes
Jun 13, 2022
iosmanthus
reviewed
Jun 13, 2022
iosmanthus
reviewed
Jun 13, 2022
iosmanthus
reviewed
Jun 13, 2022
1b95aab to
b563b4b
Compare
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
fff2720 to
06111e5
Compare
iosmanthus
reviewed
Jun 14, 2022
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
ti-srebot
previously approved these changes
Jun 14, 2022
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: Daemonxiao <735462752@qq.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
zhangyangyu
approved these changes
Jun 14, 2022
Collaborator
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. You are not a reviewer or committer or co-leader or leader. |
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jun 14, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.3 in PR #612 |
iosmanthus
pushed a commit
that referenced
this pull request
Jun 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daemonxiao 735462752@qq.com
What problem does this PR solve?
TiSpark met some problem when use TLS Reload.
Problem Description: tryReload() is used as a task in ScheduledFuture. When tryReload() throws an exception, the schedule will be suppressed which makes tryReload() will not work.
What is changed and how does it work?
Add try-catch in tryReload().
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes