[close #606]: change the default prefix for API v2#607
Merged
iosmanthus merged 5 commits intotikv:masterfrom Jun 6, 2022
Merged
[close #606]: change the default prefix for API v2#607iosmanthus merged 5 commits intotikv:masterfrom
iosmanthus merged 5 commits intotikv:masterfrom
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #607 +/- ##
============================================
- Coverage 34.60% 34.58% -0.03%
+ Complexity 1418 1415 -3
============================================
Files 278 278
Lines 17342 17344 +2
Branches 1970 1970
============================================
- Hits 6002 5998 -4
- Misses 10732 10741 +9
+ Partials 608 605 -3
Continue to review full report at Codecov.
|
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
sunxiaoguang
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #issue_number
Problem Description: Current key prefix of API v2 is not extensible enough, because no more keyspace information could be attached to it which is against the original design for the https://github.com/tikv/rfcs/blob/master/text/0069-api-v2.md.
What is changed and how does it work?
This pull request adds a reserved zero to represent the
defaultkeyspace.Check List for Tests
This PR has been tested by at least one of the following methods: