Skip to content

[close #591] update all the branch of proto while precompiling to avoid commit miss#592

Merged
zz-jason merged 1 commit intotikv:masterfrom
iosmanthus:update-proto-while-precompiling
Apr 22, 2022
Merged

[close #591] update all the branch of proto while precompiling to avoid commit miss#592
zz-jason merged 1 commit intotikv:masterfrom
iosmanthus:update-proto-while-precompiling

Conversation

@iosmanthus
Copy link
Copy Markdown
Member

Signed-off-by: iosmanthus myosmanthustree@gmail.com

What problem does this PR solve?

Issue Number: close #591

Problem Description:

Update all the branches to the latest commit while precompiling.

Related changes

  • Need to cherry-pick the release branch

Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 22, 2022

Codecov Report

Merging #592 (c43a8d4) into master (09cb452) will decrease coverage by 0.64%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #592      +/-   ##
============================================
- Coverage     33.95%   33.30%   -0.65%     
+ Complexity     1359     1332      -27     
============================================
  Files           270      270              
  Lines         17174    17174              
  Branches       1956     1956              
============================================
- Hits           5831     5720     -111     
- Misses        10729    10844     +115     
+ Partials        614      610       -4     
Impacted Files Coverage Δ
src/main/java/org/tikv/common/PDChecker.java 0.00% <0.00%> (-52.95%) ⬇️
.../java/org/tikv/common/importer/ImporterClient.java 60.00% <0.00%> (-8.89%) ⬇️
src/main/java/org/tikv/common/PDClient.java 51.31% <0.00%> (-8.16%) ⬇️
.../org/tikv/common/importer/ImporterStoreClient.java 72.72% <0.00%> (-7.58%) ⬇️
src/main/java/org/tikv/raw/RawKVClient.java 67.25% <0.00%> (-6.39%) ⬇️
...g/tikv/common/operation/iterator/ScanIterator.java 73.68% <0.00%> (-2.64%) ⬇️
...rc/main/java/io/grpc/netty/NettyClientHandler.java 56.03% <0.00%> (-1.73%) ⬇️
src/main/java/org/tikv/common/region/TiStore.java 61.53% <0.00%> (+5.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09cb452...c43a8d4. Read the comment docs.

@zz-jason zz-jason merged commit 7a123a0 into tikv:master Apr 22, 2022
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Apr 22, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Collaborator

cherry pick to release-3.1 in PR #593

ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Apr 22, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Copy Markdown
Collaborator

cherry pick to release-3.2 in PR #594

zz-jason pushed a commit that referenced this pull request Apr 22, 2022
…id commit miss (#592) (#594)

Co-authored-by: iosmanthus <dengliming@pingcap.com>
iosmanthus added a commit that referenced this pull request Apr 22, 2022
iosmanthus added a commit that referenced this pull request Apr 24, 2022
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
zz-jason pushed a commit that referenced this pull request Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proto repo commit missing

3 participants