Merged
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
============================================
+ Coverage 33.87% 33.93% +0.06%
- Complexity 1358 1360 +2
============================================
Files 270 270
Lines 17131 17174 +43
Branches 1950 1956 +6
============================================
+ Hits 5803 5828 +25
- Misses 10717 10731 +14
- Partials 611 615 +4
Continue to review full report at Codecov.
|
zz-jason
reviewed
Apr 18, 2022
Member
zz-jason
left a comment
There was a problem hiding this comment.
codev has commented on the uncovered codes in this PR, could you add some tests for it?
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Member
Author
|
@zz-jason PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #588
Problem Description:
For now, client-java doesn't support TLS cert reloading, this pull request tries to enable this feature on master.
What is changed and how does it work?
Check if the cert files are changed while calling
getChannelinChannelFactory.Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Related changes