[fix #537] fix convert byte[] to long error#538
Merged
zz-jason merged 8 commits intotikv:masterfrom Mar 29, 2022
Merged
Conversation
Member
|
@shiyuhang0 thanks for your contribution! please:
|
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
============================================
+ Coverage 33.23% 34.06% +0.83%
- Complexity 1338 1361 +23
============================================
Files 270 270
Lines 17131 17131
Branches 1950 1950
============================================
+ Hits 5693 5836 +143
+ Misses 10833 10681 -152
- Partials 605 614 +9
Continue to review full report at Codecov.
|
194d8aa to
ddd4dbd
Compare
Collaborator
Author
have done, PTAL |
Collaborator
Author
|
/run-all-tests |
Member
|
@shiyuhang0 please fix license check and code format check failures. |
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
5c72c8d to
022ac19
Compare
Collaborator
Author
done |
Collaborator
Author
Member
|
Rest LGTM. However, @marsishandsome is working on removing the coprocessor code out of the code base. This pull request might suffer from this change. |
ti-srebot
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: fix #537
Problem Description: convert byte[] to long error in TiChunkColumnVector#getLongFromBinary
What is changed and how it works?
When long and byte do
|operation, I guess byte is converted to long, It make the wrong answer.So, Use 0xff to intercept the last eight binary data
Check List for Tests
This PR has been tested by the at least one of the following methods:
Side effects
Related changes