[to #526] Add codecov on Github Action by andylokandy · Pull Request #524 · tikv/client-java

andylokandy · 2022-02-15T10:37:30Z

Signed-off-by: andylokandy andylokandy@hotmail.com

Ref #526

What is changed and how it works?

Add CI using Github Action. Intended to replace jenkins.

Code changes

No code

Check List for Tests

No code

zz-jason · 2022-02-16T04:28:11Z

@andylokandy please create an issue for this PR and follow the PR title format as others.

.github/workflows/ci.yml

Signed-off-by: andylokandy <andylokandy@hotmail.com>

codecov · 2022-02-16T14:50:56Z

Codecov Report

❗ No coverage uploaded for pull request base (master@b30a8ff). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 879ae78 differs from pull request most recent head 2cefaba. Consider uploading reports for the commit 2cefaba to get more accurate results

@@            Coverage Diff            @@
##             master     #524   +/-   ##
=========================================
  Coverage          ?   30.66%           
  Complexity        ?     1265           
=========================================
  Files             ?      278           
  Lines             ?    17343           
  Branches          ?     1975           
=========================================
  Hits              ?     5318           
  Misses            ?    11439           
  Partials          ?      586

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b30a8ff...2cefaba. Read the comment docs.

Signed-off-by: andylokandy <andylokandy@hotmail.com>

.github/workflows/ci.yml

Signed-off-by: andylokandy <andylokandy@hotmail.com>

iosmanthus · 2022-02-17T08:07:24Z

.github/workflows/ci.yml

+        run: curl --proto '=https' --tlsv1.2 -sSf https://tiup-mirrors.pingcap.com/install.sh | sh
+      - name: Start TiUP Playground
+        run: |
+          /home/runner/.tiup/bin/tiup playground ${{ matrix.tikv_version }} --mode tikv-slim --kv 1 --without-monitor --kv.config /home/runner/work/client-java/client-java/.github/config/tikv_rawkv.toml --pd.config /home/runner/work/client-java/client-java/.github/config/pd.toml &> raw.out 2>&1 &


What about adding a step to install necessary components via tiup install <components>:<version>, then we may need not to sleep too long.

It will add up the complexity of deciding which components are required by the playground.

Only PD and TiKV are needed.

ngm may be needed afterwards

I've tested with various ways but tiup seems too easy to run into race conditions so that the sleep time can not be eliminated. So I've reverted all attempts for tiup install.

Signed-off-by: andylokandy <andylokandy@hotmail.com>

zz-jason

LGTM

zz-jason · 2022-02-17T14:01:25Z

.github/workflows/ci.yml

+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        tikv_version: [nightly, v5.0.4, v5.3.0, v5.4.0]


oh, how about [v5.0.0, v5.1.0, v5.2.0, v5.3.0, v5.4.0]?

is there a way to point to the latest patch release on each major.minor.patch tikv version?

I'm afraid it's too much for pull request ci. It's better to do it on release or nightly ci. Anyway, tiup list tikv | awk '{print $1}' should do the job.

marsishandsome

LGTM

zz-jason

LGTM

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2022-02-18T02:05:10Z

cherry pick to release-3.1 in PR #533

Co-authored-by: Andy Lok <andylokandy@hotmail.com>

zz-jason · 2022-03-22T08:48:12Z

/run-cherry-picker

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2022-03-22T08:48:42Z

cherry pick to release-3.2 in PR #562

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Andy Lok <andylokandy@hotmail.com>

andylokandy changed the title ~~Add build test on Github Action~~ [to #526] Add build test on Github Action Feb 16, 2022

zz-jason reviewed Feb 16, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

test

1fad664

Signed-off-by: andylokandy <andylokandy@hotmail.com>

andylokandy force-pushed the ci branch from ad841f8 to 1fad664 Compare February 16, 2022 10:40

andylokandy added 7 commits February 16, 2022 19:14

test

9fbc2d4

Signed-off-by: andylokandy <andylokandy@hotmail.com>

test

3283373

Signed-off-by: andylokandy <andylokandy@hotmail.com>

test

415c247

Signed-off-by: andylokandy <andylokandy@hotmail.com>

test

16c46f6

Signed-off-by: andylokandy <andylokandy@hotmail.com>

test

466c363

Signed-off-by: andylokandy <andylokandy@hotmail.com>

Add coverage

0fc0c18

Signed-off-by: andylokandy <andylokandy@hotmail.com>

Elevate permission

568cd77

Signed-off-by: andylokandy <andylokandy@hotmail.com>

github-actions bot added the component/config label Feb 16, 2022

use codecov

7786501

Signed-off-by: andylokandy <andylokandy@hotmail.com>

andylokandy closed this Feb 16, 2022

andylokandy reopened this Feb 16, 2022

fix

fd69ab9

Signed-off-by: andylokandy <andylokandy@hotmail.com>

andylokandy requested review from iosmanthus, marsishandsome and zz-jason February 16, 2022 14:53

add baget

9891d24

Signed-off-by: andylokandy <andylokandy@hotmail.com>

andylokandy added the needs-cherry-pick-3.1 label Feb 16, 2022

andylokandy changed the title ~~[to #526] Add build test on Github Action~~ [to #526] Add codecov on Github Action Feb 16, 2022

zz-jason reviewed Feb 17, 2022

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.github/workflows/ci.yml Show resolved Hide resolved

andylokandy added 3 commits February 17, 2022 15:55

address comment

a7dedd2

Signed-off-by: andylokandy <andylokandy@hotmail.com>

address comment

6d539bf

Signed-off-by: andylokandy <andylokandy@hotmail.com>

Merge branch 'master' into ci

4bdddcc

iosmanthus reviewed Feb 17, 2022

View reviewed changes

add comment

2cefaba

Signed-off-by: andylokandy <andylokandy@hotmail.com>

zz-jason approved these changes Feb 17, 2022

View reviewed changes

ti-srebot added the status/LGT1 label Feb 17, 2022

zz-jason reviewed Feb 17, 2022

View reviewed changes

andylokandy force-pushed the ci branch from 879ae78 to 2cefaba Compare February 17, 2022 15:01

andylokandy linked an issue Feb 17, 2022 that may be closed by this pull request

Add coverage report to CI #526

Closed

2 tasks

marsishandsome approved these changes Feb 18, 2022

View reviewed changes

ti-srebot removed the status/LGT1 label Feb 18, 2022

ti-srebot approved these changes Feb 18, 2022

View reviewed changes

ti-srebot added the status/LGT2 label Feb 18, 2022

zz-jason approved these changes Feb 18, 2022

View reviewed changes

zz-jason merged commit 49476d7 into tikv:master Feb 18, 2022

ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Feb 18, 2022

cherry pick tikv#524 to release-3.1

5f4092e

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Feb 18, 2022

[to #526] Add codecov on Github Action (#524) #533

Merged

zz-jason pushed a commit that referenced this pull request Feb 21, 2022

[to #526] Add codecov on Github Action (#524) (#533)

bbf9e19

Co-authored-by: Andy Lok <andylokandy@hotmail.com>

zz-jason added the needs-cherry-pick-3.2 label Mar 22, 2022

ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Mar 22, 2022

cherry pick tikv#524 to release-3.2

026412c

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot mentioned this pull request Mar 22, 2022

[to #526] Add codecov on Github Action (#524) #562

Merged

zz-jason pushed a commit that referenced this pull request Mar 22, 2022

cherry pick #524 to release-3.2 (#562)

d9a377f

Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: Andy Lok <andylokandy@hotmail.com>

Conversation

andylokandy commented Feb 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed and how it works?

Code changes

Check List for Tests

Uh oh!

zz-jason commented Feb 16, 2022

Uh oh!

Uh oh!

codecov bot commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iosmanthus Feb 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andylokandy Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

iosmanthus Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

andylokandy Feb 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andylokandy Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

zz-jason left a comment

Choose a reason for hiding this comment

Uh oh!

zz-jason Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

zz-jason Feb 17, 2022

Choose a reason for hiding this comment

Uh oh!

andylokandy Feb 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

marsishandsome left a comment

Choose a reason for hiding this comment

Uh oh!

zz-jason left a comment

Choose a reason for hiding this comment

Uh oh!

ti-srebot commented Feb 18, 2022

Uh oh!

zz-jason commented Mar 22, 2022

Uh oh!

ti-srebot commented Mar 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

andylokandy commented Feb 15, 2022 •

edited

Loading

codecov bot commented Feb 16, 2022 •

edited

Loading

iosmanthus Feb 17, 2022 •

edited

Loading

andylokandy Feb 17, 2022 •

edited

Loading

andylokandy Feb 17, 2022 •

edited

Loading