[close #489 ] fix backoffer data race#490
Merged
marsishandsome merged 7 commits intotikv:masterfrom Jan 21, 2022
Merged
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Collaborator
|
/run-all-tests |
zz-jason
reviewed
Jan 21, 2022
ti-srebot
approved these changes
Jan 21, 2022
ti-srebot
pushed a commit
to ti-srebot/client-java
that referenced
this pull request
Jan 21, 2022
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
|
cherry pick to release-3.1 in PR #494 |
marsishandsome
pushed a commit
that referenced
this pull request
Jan 21, 2022
* cherry pick #490 to release-3.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * fix license error Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Co-authored-by: iosmanthus <dengliming@pingcap.com> Co-authored-by: iosmanthus <myosmanthustree@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: close #489
ConcreteBackOffermay trigger by multiple threads but thebackOffFunctionMapisHashMapwhich is not thread-safe. This might trigger a race exception while this backoffer is shared between threads.