[to #464] add unit tests for exported API of RawKVClient#471
Merged
zz-jason merged 8 commits intotikv:masterfrom Mar 24, 2022
Merged
[to #464] add unit tests for exported API of RawKVClient#471zz-jason merged 8 commits intotikv:masterfrom
zz-jason merged 8 commits intotikv:masterfrom
Conversation
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
9 tasks
zz-jason
reviewed
Jan 5, 2022
zz-jason
previously approved these changes
Jan 6, 2022
Member
zz-jason
left a comment
There was a problem hiding this comment.
LGTM
@iosmanthus you can solve the issues in another pull request
Member
Author
|
@marsishandsome PTAL |
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
============================================
+ Coverage 32.59% 32.94% +0.35%
- Complexity 1324 1329 +5
============================================
Files 270 270
Lines 17054 17054
Branches 1950 1950
============================================
+ Hits 5559 5619 +60
+ Misses 10889 10829 -60
Partials 606 606
Continue to review full report at Codecov.
|
ti-srebot
previously approved these changes
Mar 23, 2022
Member
|
@iosmanthus please resolve conflicts. |
…it-tests-for-rawkv-client Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
6913f87
Member
Author
|
@zz-jason @marsishandsome PTAL |
marsishandsome
approved these changes
Mar 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: iosmanthus myosmanthustree@gmail.com
What problem does this PR solve?
Issue Number: to #464
Problem Description:
Some of the exported API of
RawKVClientis not covered by unit tests and this blocks the compatibility tests. This pull request add more tests to cover these APIs including:Check List for Tests
This PR has been tested by at least one of the following methods: