[close #350] add a flag to determine if TiFlash is enabled (#351)#374
Closed
ti-srebot wants to merge 2 commits intotikv:release-3.1from
Closed
[close #350] add a flag to determine if TiFlash is enabled (#351)#374ti-srebot wants to merge 2 commits intotikv:release-3.1from
ti-srebot wants to merge 2 commits intotikv:release-3.1from
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Collaborator
Author
|
/run-all-tests |
birdstorm
requested changes
Dec 9, 2021
Collaborator
birdstorm
left a comment
birdstorm
left a comment
There was a problem hiding this comment.
please resolve conflicts
zz-jason
changed the title
Signed-off-by: Jian Zhang <zjsariel@gmail.com>
Member
|
@birdstorm PTAL again, thanks. |
Collaborator
marsishandsome
left a comment
marsishandsome
left a comment
There was a problem hiding this comment.
This PR is not necessary to cherry-pick to to 3.1/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #351 to release-3.1
You can switch your code base to this Pull Request by using git-extras:
# In client-java repo: git pr https://github.com/tikv/client-java/pull/374After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
TiKV client currently assumes that TiFlash is deployed and starts a threadpool to periodically check tiflash replica status
#350
What is changed and how it works?
Added a boolean flag to determine if tiflash is enabled . The default value is false.
Check List
Tests
Code changes
Side effects
Related changes