add slow log by marsishandsome · Pull Request #328 · tikv/client-java

marsishandsome · 2021-11-17T04:38:24Z

Signed-off-by: marsishandsome marsishandsome@gmail.com

What problem does this PR solve?

add slow log

What is changed and how it works?

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility

Related changes

Need to cherry-pick to the release branch
Need to update the documentation
Need to be included in the release note

src/main/java/org/tikv/common/ConfigUtils.java

src/main/java/org/tikv/common/log/SlowLogImpl.java

src/main/java/org/tikv/common/log/SlowLogTask.java

src/main/java/org/tikv/common/log/SlowLogTaskEmptyImpl.java

src/main/java/org/tikv/common/log/SlowLogTaskImpl.java

src/main/java/org/tikv/common/policy/RetryPolicy.java

src/main/java/org/tikv/raw/RawKVClient.java

src/test/java/org/tikv/raw/RawKVClientTest.java

src/main/java/org/tikv/common/ConfigUtils.java

src/main/java/org/tikv/common/log/SlowLogImpl.java

src/main/java/org/tikv/common/log/SlowLogSpan.java

src/main/java/org/tikv/common/log/SlowLogSpanImpl.java

src/main/java/org/tikv/common/policy/RetryPolicy.java

src/main/java/org/tikv/common/util/BackOffer.java

src/main/java/org/tikv/raw/RawKVClient.java

src/main/java/org/tikv/common/policy/RetryPolicy.java

src/main/java/org/tikv/common/util/ConcreteBackOffer.java

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

marsishandsome · 2021-11-19T06:33:13Z

/run-all-tests

birdstorm

LGTM

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

marsishandsome · 2021-11-19T08:06:23Z

/run-all-tests

src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java

src/main/java/org/tikv/common/log/SlowLogImpl.java

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

marsishandsome · 2021-11-19T08:40:33Z

/run-all-tests

birdstorm

LGTM

zz-jason

LGTM

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

marsishandsome force-pushed the feature/add-slow-log branch 18 times, most recently from 5d95a5d to ad64759 Compare November 18, 2021 08:18

zz-jason reviewed Nov 18, 2021

View reviewed changes

src/main/java/org/tikv/common/ConfigUtils.java Outdated Show resolved Hide resolved

marsishandsome force-pushed the feature/add-slow-log branch 2 times, most recently from 6a2d285 to c48eec8 Compare November 18, 2021 09:14

zz-jason reviewed Nov 18, 2021

View reviewed changes

src/main/java/org/tikv/common/log/SlowLogImpl.java Outdated Show resolved Hide resolved

zz-jason reviewed Nov 18, 2021

View reviewed changes

src/main/java/org/tikv/common/ConfigUtils.java Outdated Show resolved Hide resolved

marsishandsome force-pushed the feature/add-slow-log branch 4 times, most recently from f739b48 to 7b8554a Compare November 18, 2021 10:25

zz-jason reviewed Nov 18, 2021

View reviewed changes

marsishandsome force-pushed the feature/add-slow-log branch 8 times, most recently from f33da0a to ff05f70 Compare November 19, 2021 05:20

marsishandsome added 3 commits November 19, 2021 13:24

add slow log

c786eb8

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

support SwitchLeader and gRPC Forward

17c878a

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

add slow log time

5303520

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

marsishandsome force-pushed the feature/add-slow-log branch from ff05f70 to 5303520 Compare November 19, 2021 05:24

birdstorm previously approved these changes Nov 19, 2021

View reviewed changes

ti-srebot added the status/LGT1 label Nov 19, 2021

rename timeout to threshold

dcbc172

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

marsishandsome dismissed birdstorm’s stale review via dcbc172 November 19, 2021 08:06

zz-jason reviewed Nov 19, 2021

View reviewed changes

src/main/java/org/tikv/common/region/AbstractRegionStoreClient.java Show resolved Hide resolved

src/main/java/org/tikv/common/log/SlowLogImpl.java Outdated Show resolved Hide resolved

address code review

5684904

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

marsishandsome force-pushed the feature/add-slow-log branch from e9becd2 to 5684904 Compare November 19, 2021 08:39

birdstorm approved these changes Nov 19, 2021

View reviewed changes

zz-jason approved these changes Nov 19, 2021

View reviewed changes

ti-srebot removed the status/LGT1 label Nov 19, 2021

ti-srebot approved these changes Nov 19, 2021

View reviewed changes

ti-srebot added the status/LGT2 label Nov 19, 2021

marsishandsome merged commit a881a65 into tikv:release-3.1 Nov 19, 2021

marsishandsome mentioned this pull request Dec 1, 2021

Batch cherry pick from release-3.1 #356

Merged

marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Dec 1, 2021

add slow log (tikv#328)

cbce07b

Signed-off-by: marsishandsome <marsishandsome@gmail.com>

Conversation

marsishandsome commented Nov 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how it works?

Check List

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marsishandsome commented Nov 19, 2021

Uh oh!

birdstorm left a comment

Choose a reason for hiding this comment

Uh oh!

marsishandsome commented Nov 19, 2021

Uh oh!

Uh oh!

Uh oh!

marsishandsome commented Nov 19, 2021

Uh oh!

birdstorm left a comment

Choose a reason for hiding this comment

Uh oh!

zz-jason left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marsishandsome commented Nov 17, 2021 •

edited

Loading