Merged
Conversation
marsishandsome
force-pushed
the
feature/support-tls
branch
8 times, most recently
from
efd68da to
a07b873
Compare
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/support-tls
branch
from
a07b873 to
c0775f7
Compare
Collaborator
Author
|
/run-all-tests |
andylokandy
reviewed
Sep 24, 2021
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome
force-pushed
the
feature/support-tls
branch
from
ce1d80a to
d7b60c0
Compare
andylokandy
approved these changes
Sep 24, 2021
kolbe
reviewed
Sep 24, 2021
Collaborator
Author
|
/run-all-tests |
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Collaborator
Author
|
/run-all-tests |
dveeden
reviewed
Sep 27, 2021
dveeden
left a comment
dveeden
left a comment
There was a problem hiding this comment.
Is there anything we need to do now (or later as follow-up) for:
- Restricting this to TLSv1.1 or newer?
- Removing insecure cipher suites (like 3DES)?
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Collaborator
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: marsishandsome marsishandsome@gmail.com
What problem does this PR solve?
#267
What is changed and how it works?
support tls
Check List
Tests
Code changes
Side effects
Related changes