Skip to content

add configuration parameter for RawKV backoff#246

Merged
marsishandsome merged 1 commit intotikv:masterfrom
marsishandsome:feature/add-timeout-config
Aug 5, 2021
Merged

add configuration parameter for RawKV backoff#246
marsishandsome merged 1 commit intotikv:masterfrom
marsishandsome:feature/add-timeout-config

Conversation

@marsishandsome
Copy link
Copy Markdown
Collaborator

@marsishandsome marsishandsome commented Aug 5, 2021 •
edited
Loading

What problem does this PR solve?

add configuration parameter for RawKV backoff

What is changed and how it works?

tikv.rawkv.default_timeout_in_ms

  • RawKV default timeout in milliseconds
  • default: 20000 (20 seconds)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@marsishandsome marsishandsome force-pushed the feature/add-timeout-config branch from 29ddca3 to a993813 Compare August 5, 2021 02:35
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Aug 5, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/add-timeout-config branch from a993813 to 235abe6 Compare August 5, 2021 02:54
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Aug 5, 2021

/run-all-tests

@marsishandsome marsishandsome force-pushed the feature/add-timeout-config branch from 235abe6 to 38e37fe Compare August 5, 2021 02:59
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Aug 5, 2021

/run-all-tests

@marsishandsome marsishandsome requested review from andylokandy and birdstorm and removed request for andylokandy August 5, 2021 03:00
@marsishandsome marsishandsome force-pushed the feature/add-timeout-config branch from 38e37fe to 8093a15 Compare August 5, 2021 03:59
@marsishandsome marsishandsome changed the title add configuration parameter for RawKV timeout add configuration parameter for RawKV backoff Aug 5, 2021
@marsishandsome marsishandsome force-pushed the feature/add-timeout-config branch from 8093a15 to 9dff6d7 Compare August 5, 2021 04:00
@marsishandsome
add configration parameter for RawKV timeout
9e647a7 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome force-pushed the feature/add-timeout-config branch from 9dff6d7 to 9e647a7 Compare August 5, 2021 04:01
@marsishandsome
Copy link
Copy Markdown
Collaborator Author

marsishandsome commented Aug 5, 2021

/run-all-tests

birdstorm
birdstorm approved these changes Aug 5, 2021
View reviewed changes
Copy link
Copy Markdown
Collaborator

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marsishandsome marsishandsome merged commit 5aebd12 into tikv:master Aug 5, 2021
ti-srebot pushed a commit to ti-srebot/client-java that referenced this pull request Aug 5, 2021
@marsishandsome @ti-srebot
cherry pick tikv#246 to release-3.1
81b9815 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 5, 2021
Closed
@ti-srebot
Copy link
Copy Markdown
Collaborator

ti-srebot commented Aug 5, 2021

cherry pick to release-3.1 in PR #249

marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Aug 5, 2021
@marsishandsome
add configration parameter for RawKV timeout (tikv#246)
8813b2f 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
@marsishandsome marsishandsome mentioned this pull request Aug 5, 2021
Merged
marsishandsome added a commit to marsishandsome/client-java that referenced this pull request Aug 6, 2021
@marsishandsome
add configration parameter for RawKV timeout (tikv#246)
b151d75 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
marsishandsome added a commit that referenced this pull request Aug 6, 2021
@marsishandsome
add configration parameter for RawKV timeout (#246) (#250)
d9a834b 
Signed-off-by: marsishandsome <marsishandsome@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@birdstorm birdstorm birdstorm approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees

No one assigned

Labels

status/LGT1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marsishandsome @ti-srebot @birdstorm